Allow automatic dynamic shapes for closures and set current node properly in flexattention subgraph lowering #137043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erly in flexattention subgraph lowering [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137043
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 1521a72 with merge base b825848 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…t node properly in flexattention subgraph lowering" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec [ghstack-poisoned]
…t node properly in flexattention subgraph lowering" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec [ghstack-poisoned]
…t node properly in flexattention subgraph lowering" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec [ghstack-poisoned]
drisspg
approved these changes
Oct 1, 2024
Contributor
drisspg
left a comment
drisspg
left a comment
There was a problem hiding this comment.
Setting graph node looks good, dont know what is_cell_contents does
This was referenced Oct 1, 2024
injiiiiil
pushed a commit
to injiiiiil/654
that referenced
this pull request
Oct 1, 2024
…erly in flexattention subgraph lowering ghstack-source-id: cc1eb52 Pull Request resolved: pytorch/pytorch#137043
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Pull Request resolved: #137049 Approved by: https://github.com/zou3519, https://github.com/drisspg, https://github.com/yanboliang ghstack dependencies: #136826, #137043
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 2, 2024
Pull Request resolved: #137065 Approved by: https://github.com/drisspg, https://github.com/Skylion007 ghstack dependencies: #136826, #137043, #137049
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
…erly in flexattention subgraph lowering (pytorch#137043) Pull Request resolved: pytorch#137043 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#136826
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
Pull Request resolved: pytorch#137049 Approved by: https://github.com/zou3519, https://github.com/drisspg, https://github.com/yanboliang ghstack dependencies: pytorch#136826, pytorch#137043
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
) Pull Request resolved: pytorch#137065 Approved by: https://github.com/drisspg, https://github.com/Skylion007 ghstack dependencies: pytorch#136826, pytorch#137043, pytorch#137049
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 2, 2024
I think this should basically make no difference numerically, but it does have some ramifications on things like CSE. Pull Request resolved: #137079 Approved by: https://github.com/Skylion007 ghstack dependencies: #136826, #137043, #137049, #137065
Esquains
pushed a commit
to Esquains/study1
that referenced
this pull request
Dec 15, 2024
…erly in flexattention subgraph lowering ghstack-source-id: 9b439e8 Pull Request resolved: pytorch/pytorch#137043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @rec