[logging/debugging] handle None (constant) args in debug log #137032
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137032
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit f150c7d with merge base 1f3a793 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63652564 |
angelayi
approved these changes
Sep 30, 2024
coconutruben
force-pushed
the
export-D63652564
branch
from
0347578 to
c8a7458
Compare
coconutruben
added a commit
to coconutruben/pytorch
that referenced
this pull request
Sep 30, 2024
…#137032) Summary: Pull Request resolved: pytorch#137032 # Why The arguments are filtered out as they are just const in the compiled graph, but the logger still expects a non-None type # What When passing a filtered out arg (None) to the debug logger, just log that it's a filtered out argument, instead of throwing a Type error also add unit test to capture this behavior going forward # Background pytorch#131594 Test Plan: - execute repro from pytorch#135584 (comment) with and without the edits Reviewed By: angelayi Differential Revision: D63652564
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63652564 |
coconutruben
force-pushed
the
export-D63652564
branch
from
c8a7458 to
3a632df
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63652564 |
coconutruben
force-pushed
the
export-D63652564
branch
from
3a632df to
9035394
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63652564 |
coconutruben
added a commit
to coconutruben/pytorch
that referenced
this pull request
Oct 1, 2024
…#137032) Summary: Pull Request resolved: pytorch#137032 # Why The arguments are filtered out as they are just const in the compiled graph, but the logger still expects a non-None type # What When passing a filtered out arg (None) to the debug logger, just log that it's a filtered out argument, instead of throwing a Type error also add unit test to capture this behavior going forward # Background pytorch#131594 Test Plan: - execute repro from pytorch#135584 (comment) with and without the edits Reviewed By: angelayi Differential Revision: D63652564
coconutruben
force-pushed
the
export-D63652564
branch
from
9035394 to
5f3dbf2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63652564 |
coconutruben
force-pushed
the
export-D63652564
branch
from
5f3dbf2 to
226c16e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63652564 |
…#137032) Summary: Pull Request resolved: pytorch#137032 # Why The arguments are filtered out as they are just const in the compiled graph, but the logger still expects a non-None type # What When passing a filtered out arg (None) to the debug logger, just log that it's a filtered out argument, instead of throwing a Type error also add unit test to capture this behavior going forward # Background pytorch#131594 Test Plan: - execute repro from pytorch#135584 (comment) with and without the edits Reviewed By: angelayi Differential Revision: D63652564
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63652564 |
coconutruben
force-pushed
the
export-D63652564
branch
from
226c16e to
f150c7d
Compare
Contributor
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
…#137032) Summary: # Why The arguments are filtered out as they are just const in the compiled graph, but the logger still expects a non-None type # What When passing a filtered out arg (None) to the debug logger, just log that it's a filtered out argument, instead of throwing a Type error # Background pytorch#131594 Test Plan: - execute repro from pytorch#135584 (comment) with and without the edits Differential Revision: D63652564 Pull Request resolved: pytorch#137032 Approved by: https://github.com/angelayi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Why
The arguments are filtered out as they are just const in the compiled graph, but the logger still expects a non-None type
What
When passing a filtered out arg (None) to the debug logger, just log that it's a filtered out argument, instead of throwing a Type error
Background
#131594
Test Plan: - execute repro from #135584 (comment) with and without the edits
Differential Revision: D63652564
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @rec