Skip to content

Fix lint #137023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

Fix lint #137023

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 30, 2024 •
edited
Loading

By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138

@malfet
Fix lint
ca09f6a 
By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138
@malfet malfet requested a review from a team as a code owner September 30, 2024 18:16
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137023

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ca09f6a with merge base 3ff2d93 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 30, 2024
kit1980
kit1980 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kit1980 kit1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also update later in the file:

  - name: Setup Python 3.8
    if: matrix.test_type != 'older_python_version'
    uses: actions/setup-python@v4
    with:
      python-version: '3.8'

@kit1980
Copy link
Contributor

kit1980 commented Sep 30, 2024

Should also update later in the file:

Or maybe not.
For collect_env we install pip install 'torch==1.*', so maybe 3.8 is ok.

@malfet
Copy link
Contributor Author

malfet commented Sep 30, 2024

@pytorchbot merge -f "It fixed the regression"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Sep 30, 2024

@pytorchbot cherry-pick -b release/2.5 -c ci

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: 'ci' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor Author

malfet commented Sep 30, 2024

@pytorchbot cherry-pick -c regression --onto release/2.5

pytorchbot pushed a commit that referenced this pull request Sep 30, 2024
@malfet @pytorchbot
Fix lint (#137023)
777c516 
By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138

Pull Request resolved: #137023
Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007

(cherry picked from commit 40f80a7)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Sep 30, 2024

Cherry picking #137023

The cherry pick PR is at #137052 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Sep 30, 2024
Closed
malfet added a commit that referenced this pull request Sep 30, 2024
@pytorchbot @malfet
Fix lint (#137052)
57717c8 
Fix lint (#137023)

By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138

Pull Request resolved: #137023
Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007

(cherry picked from commit 40f80a7)

Co-authored-by: Nikita Shulga <[email protected]>
@malfet malfet mentioned this pull request Oct 1, 2024
Closed
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@malfet @AnantGulati
Fix lint (pytorch#137023)
f695ea7 
By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by pytorch#132138

Pull Request resolved: pytorch#137023
Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007
@github-actions github-actions bot deleted the malfet-patch-32 branch November 3, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@ZainRizvi ZainRizvi ZainRizvi approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@malfet @kit1980 @pytorchmergebot @pytorchbot @seemethere @Skylion007 @ZainRizvi @janeyx99