Skip to content

Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes #137019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang wants to merge 3 commits into from
Closed

Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes #137019

ezyang wants to merge 3 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 30, 2024 •
edited
Loading

@ezyang
Update
79c921b 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137019

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 158 Pending

As of commit 4a3c1fa with merge base failed to retrieve merge base, please contact dev infra:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang ezyang mentioned this pull request Sep 30, 2024
Closed
@ezyang ezyang added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Sep 30, 2024
ezyang
ezyang commented Sep 30, 2024
View reviewed changes
torch/fx/experimental/symbolic_shapes.py

fs = shape_env.pending_fresh_unbacked_symbols
pending = set(fs)
if pending:
Copy link
Contributor Author

@ezyang ezyang Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do this part with ignore indentation change

@ezyang
Update
3ef7749 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Sep 30, 2024
@ezyang
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes
da5b16e 
Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: b105f28
Pull Request resolved: #137019
@ezyang
Update
4a3c1fa 
[ghstack-poisoned]
This was referenced Oct 1, 2024
Closed
Closed
ezyang added a commit that referenced this pull request Oct 1, 2024
@ezyang
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes
8a55b10 
Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: 7455a3a
Pull Request resolved: #137019
@ezyang
Copy link
Contributor Author

ezyang commented Oct 1, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Oct 1, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged while ignoring the following 3 checks: pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 5, 5, lf.linux.g5.4xlarge.nvidia.gpu), inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100), trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 2, 5, lf.linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Copy link
Contributor Author

ezyang commented Oct 1, 2024

@pytorchbot merge -f "ci failures unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes (p…
a5e103d 
…ytorch#137019)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: pytorch#137019
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136934, pytorch#136935, pytorch#136972
@lw lw mentioned this pull request Oct 28, 2024
Closed
@github-actions github-actions bot deleted the gh/ezyang/2949/head branch November 3, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

@ydwu4 ydwu4 Awaiting requested review from ydwu4

@angelayi angelayi Awaiting requested review from angelayi

@titaiwangms titaiwangms Awaiting requested review from titaiwangms

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@justinchuby justinchuby Awaiting requested review from justinchuby

@wschin wschin Awaiting requested review from wschin

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@pianpwk pianpwk Awaiting requested review from pianpwk

@bobrenjc93 bobrenjc93 Awaiting requested review from bobrenjc93

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor release notes: fx release notes category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @Skylion007