Skip to content

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Sep 30, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136998

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ddc2fe1 with merge base 78632b9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft September 30, 2024 13:14
@pytorch-bot pytorch-bot bot added the release notes: cpp release notes category label Sep 30, 2024
@cyyever cyyever force-pushed the api_tidy2 branch 3 times, most recently from 7b5b001 to 6d88c48 Compare September 30, 2024 14:15
@cyyever cyyever changed the title Api tidy2 [2/N] Fix clang-tidy warnings in torch/csrc/api/ Sep 30, 2024
@cyyever cyyever added NNC topic: not user facing topic category and removed NNC labels Sep 30, 2024
@cyyever cyyever marked this pull request as ready for review October 1, 2024 00:55
@cyyever cyyever marked this pull request as draft October 1, 2024 06:53
@cyyever cyyever marked this pull request as ready for review October 4, 2024 11:46
@cyyever cyyever requested a review from Skylion007 October 4, 2024 11:47
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 4, 2024
@cyyever cyyever requested a review from Skylion007 October 4, 2024 23:38
@cyyever cyyever marked this pull request as draft October 9, 2024 02:39
@cyyever cyyever marked this pull request as ready for review October 13, 2024 01:47
@cyyever cyyever requested a review from ezyang October 13, 2024 01:47
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 16, 2024

@pytorchmergebot merge -f "CI passed before conflict."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source release notes: cpp release notes category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants