Skip to content

[AOTI] Update sam_fast from timeout to fail_to_run #136996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
desertfire wants to merge 1 commit into from
Closed

[AOTI] Update sam_fast from timeout to fail_to_run #136996

desertfire wants to merge 1 commit into from

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Sep 30, 2024 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

Summary: sam_fast changes from timeout to fail_to_run after #136591, which "regressed" in a good way. Update the expected result file and continue investigating.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec

@desertfire
[AOTI] Update sam_fast from timeout to fail_to_run
4fd5623 
Summary: sam_fast changes from timeout to fail_to_run after #136591, which "regressed" in a good way. Update the expected result file and continue investigating.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136996

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Unrelated Failures

As of commit 4fd5623 with merge base 156ca01 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

desertfire added a commit that referenced this pull request Sep 30, 2024
@desertfire
[AOTI] Update sam_fast from timeout to fail_to_run
e3510ab 
Summary: sam_fast changes from timeout to fail_to_run after #136591, which "regressed" in a good way. Update the expected result file and continue investigating.

ghstack-source-id: b627ce5
Pull Request resolved: #136996
@desertfire desertfire added the topic: not user facing topic category label Sep 30, 2024
@desertfire
Copy link
Contributor Author

desertfire commented Sep 30, 2024

@pytorchbot merge -f "forward fix"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@desertfire @AnantGulati
[AOTI] Update sam_fast from timeout to fail_to_run (pytorch#136996)
8a26c70 
Summary: sam_fast changes from timeout to fail_to_run after pytorch#136591, which "regressed" in a good way. Update the expected result file and continue investigating.

Pull Request resolved: pytorch#136996
Approved by: https://github.com/ezyang
@github-actions github-actions bot deleted the gh/desertfire/475/head branch November 3, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@desertfire @pytorchmergebot @ezyang