Skip to content

Turn on type-checking in torch.fx.experimental.symbolic_shapes #136972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang wants to merge 4 commits into from
Closed

Turn on type-checking in torch.fx.experimental.symbolic_shapes #136972

ezyang wants to merge 4 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 30, 2024 •
edited
Loading

@ezyang
Update
c713182 
[ghstack-poisoned]
This was referenced Sep 30, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136972

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 147 Pending

As of commit ca05599 with merge base failed to retrieve merge base, please contact dev infra:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: cpu CPU specific problem (e.g., perf, algorithm) release notes: fx release notes category labels Sep 30, 2024
@ezyang ezyang added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Sep 30, 2024
@ezyang
Update
2215c62 
[ghstack-poisoned]
Skylion007
Skylion007 reviewed Sep 30, 2024
View reviewed changes
torch/_dynamo/output_graph.py
assert arg.fake_tensor is not None

def bind_symint(s, prop):
def bind_symint(s: torch.SymInt, prop):
Copy link
Collaborator

@Skylion007 Skylion007 Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit specify return type

Copy link
Contributor Author

@ezyang ezyang Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually a lot of untyped defs, I'm working on them in the next PR in stack

Skylion007
Skylion007 reviewed Sep 30, 2024
View reviewed changes
torch/fx/experimental/symbolic_shapes.py
and raw_u1.args[0][0] == 1
and isinstance(eq := raw_u1.args[0][1], sympy.Eq)
and (
raw_u1_args0 := cast(
Copy link
Collaborator

@Skylion007 Skylion007 Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need casting? We can't just specify the type here before the walrus op?

Copy link
Contributor Author

@ezyang ezyang Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, sympy annotates the type of args as Sequence[sympy.Basic], so the type annotation of args[0] is Basic when it needs to be a Tuple (because Piecewise). So even if we specified the type in walrus we would need to also do a mypy ignore.

Skylion007
Skylion007 reviewed Sep 30, 2024
View reviewed changes
Skylion007
Skylion007 reviewed Sep 30, 2024
View reviewed changes
@ezyang
Update
7ab9c07 
[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: Lint / Test run_test.py is usable without boto3/rockset

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100)

Details for Dev Infra team Raised by workflow job

This was referenced Sep 30, 2024
Closed
Closed
@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot merge -f "looks good"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot merge -c nosignal -m "need to back out for merge conflict"

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -c nosignal -m need to back out for merge conflict

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot revert -c nosignal -m "need to back out for merge conflict"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Sep 30, 2024
@pytorchmergebot
Revert "Turn on type-checking in torch.fx.experimental.symbolic_shapes (
8982906 
#136972)"

This reverts commit 3ff2d93.

Reverted #136972 on behalf of https://github.com/ezyang due to need to back out for merge conflict ([comment](#136972 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

@ezyang your PR has been successfully reverted.

@ezyang
Update
ca05599 
[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Oct 1, 2024
@ezyang @pytorchmergebot
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes (#…
6bd9d37 
…137019)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: #137019
Approved by: https://github.com/Skylion007
ghstack dependencies: #136934, #136935, #136972
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Turn on type-checking in torch.fx.experimental.symbolic_shapes (pytor…
411cb88 
…ch#136972)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: pytorch#136972
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136917, pytorch#136934, pytorch#136935
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@pytorchmergebot @AnantGulati
Revert "Turn on type-checking in torch.fx.experimental.symbolic_shapes (
acb761c 
pytorch#136972)"

This reverts commit 3ff2d93.

Reverted pytorch#136972 on behalf of https://github.com/ezyang due to need to back out for merge conflict ([comment](pytorch#136972 (comment)))
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Turn on type-checking in torch.fx.experimental.symbolic_shapes (pytor…
33e7cbd 
…ch#136972)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: pytorch#136972
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136934, pytorch#136935
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes (p…
a5e103d 
…ytorch#137019)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: pytorch#137019
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136934, pytorch#136935, pytorch#136972
@github-actions github-actions bot deleted the gh/ezyang/2948/head branch November 3, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@bobrenjc93 bobrenjc93 Awaiting requested review from bobrenjc93

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@pianpwk pianpwk Awaiting requested review from pianpwk

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: inductor release notes: fx release notes category Reverted suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @Skylion007