Enable ruff's unused variable checking everywhere in pytorch #136965

rec · 2024-09-29T18:03:28Z

Stack from ghstack (oldest at bottom):

-> Enable ruff's unused variable checking everywhere in pytorch #136965

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

[ghstack-poisoned]

pytorch-bot · 2024-09-29T18:03:31Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136965

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6efccdc with merge base 2293fe1 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

ghstack-source-id: 8ff6c23 Pull Request resolved: #136965

rec · 2024-09-30T15:16:11Z

One of these errors is bogus; the other one, Lint for torch/_functorch/_aot_autograd/collect_metadata_analysis.py, is fixed in a parent commit but I don't want spam the job queue by re-requesting absolutely everything.

rec · 2024-12-19T14:18:01Z

@Skylion007 - this is the last one!

Up for the honors?

albanD

🎉 🎉 🎉 🎉 🎉

albanD · 2024-12-20T15:19:40Z

torch/_inductor/codegen/cuda/cuda_template.py

-        extra_args = V.graph.sizevars.size_hints(
-            map(sympy.expand, call_args[len(expected_args) :])
-        )
+        V.graph.sizevars.size_hints(map(sympy.expand, call_args[len(expected_args) :]))


cc @eellison is this a bug and the variable should be used?

[ghstack-poisoned]

rec · 2024-12-21T15:50:50Z

@pytorchbot merge

pytorchmergebot · 2024-12-21T15:52:37Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-12-21T16:13:51Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

[ghstack-poisoned]

rec · 2024-12-21T17:17:50Z

@pytorchbot merge

pytorchmergebot · 2024-12-21T17:19:33Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-12-21T20:45:58Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch rebase origin/main returned non-zero exit code 1

Rebasing (1/1)
Auto-merging torch/ao/quantization/quantize.py
CONFLICT (content): Merge conflict in torch/ao/quantization/quantize.py
error: could not apply 320f918c0b7... Enable ruff's unused variable checking everywhere in pytorch (#136965)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Could not apply 320f918c0b7... Enable ruff's unused variable checking everywhere in pytorch (#136965)

Details for Dev Infra team

Raised by workflow job

[ghstack-poisoned]

ghstack-source-id: afae92d Pull Request resolved: #136965

rec · 2024-12-21T22:11:55Z

@pytorchbot merge

pytorchmergebot · 2024-12-21T22:13:59Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Summary: fix the build error revealed in D68075676. Build error exposed by added new `-Werror ` flag pytorch#136965 Test Plan: CI Differential Revision: D68120898

Update

369bcb9

[ghstack-poisoned]

rec mentioned this pull request Sep 29, 2024

Remove unused Python variables in torch/[_-a]* #133492

Closed

rec mentioned this pull request Sep 29, 2024

Remove unused Python variables in torch/[b-z]* #136963

Closed

pytorch-bot bot added the topic: not user facing topic category label Sep 29, 2024

This was referenced Sep 29, 2024

Fix unused Python variables in test/[a-d]* #134665

Closed

Fix unused Python variables in test/[e-z]* #136964

Closed

Fix unused Python variables outside torch/ and test/ #136359

Closed

pytorchbot added the open source label Sep 29, 2024

Update

a02cb10

[ghstack-poisoned]

rec added a commit that referenced this pull request Sep 29, 2024

Enable ruff's unused variable checking everywhere in pytorch

c3a1837

ghstack-source-id: 8ff6c23 Pull Request resolved: #136965

rec marked this pull request as ready for review September 30, 2024 15:14

rec requested a review from Skylion007 December 19, 2024 14:17

albanD approved these changes Dec 20, 2024

View reviewed changes

Update

27246e4

[ghstack-poisoned]

pytorch-bot bot added the module: dynamo label Dec 21, 2024

pytorchmergebot added the merging label Dec 21, 2024

pytorchmergebot removed the merging label Dec 21, 2024

Update

cf06319

[ghstack-poisoned]

pytorchmergebot added the merging label Dec 21, 2024

pytorchmergebot removed the merging label Dec 21, 2024

Update

6efccdc

[ghstack-poisoned]

rec added a commit that referenced this pull request Dec 21, 2024

Enable ruff's unused variable checking everywhere in pytorch

030cae0

ghstack-source-id: afae92d Pull Request resolved: #136965

pytorchmergebot added the merging label Dec 21, 2024

pytorchmergebot closed this in f1cbf4b Dec 22, 2024

pytorchmergebot added Merged and removed merging labels Dec 22, 2024

tianfengfrank mentioned this pull request Jan 13, 2025

[PT][PG] fix build error nused variable 'num_elements' #144708

Closed

github-actions bot deleted the gh/rec/71/head branch January 22, 2025 02:04

Enable ruff's unused variable checking everywhere in pytorch #136965

Enable ruff's unused variable checking everywhere in pytorch #136965

Uh oh!

Conversation

rec commented Sep 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136965

✅ No Failures

Uh oh!

rec commented Sep 30, 2024

Uh oh!

rec commented Dec 19, 2024

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

albanD Dec 20, 2024

Choose a reason for hiding this comment

Uh oh!

rec commented Dec 21, 2024

Uh oh!

pytorchmergebot commented Dec 21, 2024

Merge started

Uh oh!

pytorchmergebot commented Dec 21, 2024

Merge failed

Uh oh!

rec commented Dec 21, 2024

Uh oh!

pytorchmergebot commented Dec 21, 2024

Merge started

Uh oh!

pytorchmergebot commented Dec 21, 2024

Merge failed

Uh oh!

rec commented Dec 21, 2024

Uh oh!

pytorchmergebot commented Dec 21, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rec commented Sep 29, 2024 •

edited

Loading

pytorch-bot bot commented Sep 29, 2024 •

edited

Loading