Skip to content

[distributed][test] Remove unused variable and fix doc typo #136943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zeshengzong wants to merge 2 commits into from
Closed

[distributed][test] Remove unused variable and fix doc typo #136943

zeshengzong wants to merge 2 commits into from

Conversation

@zeshengzong
Copy link
Contributor

@zeshengzong zeshengzong commented Sep 29, 2024 •
edited by pytorch-bot bot
Loading

Refactor distributed test code:

  • Fix TODO: Remove unused variable
  • Fix doc typo
  • Migrate deprecated method call load_state_dict and save_state_dict

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @LucasLLC @MeetVadakkanchery @mhorowitz @pradeepfn

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136943

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4d17aae with merge base 156ca01 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category labels Sep 29, 2024
@zeshengzong zeshengzong marked this pull request as ready for review September 29, 2024 09:38
H-Huang
H-Huang approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@H-Huang H-Huang requested review from LucasLLC, fegin and wz337 September 30, 2024 16:03
@zeshengzong
Copy link
Contributor Author

zeshengzong commented Oct 1, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Tried to rebase and push PR #136943, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@zeshengzong
Copy link
Contributor Author

zeshengzong commented Oct 1, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@kwen2501
Copy link
Collaborator

kwen2501 commented Oct 2, 2024

@pytorchbot merge -f "Failure is from trunk"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@zeshengzong @AnantGulati
[distributed][test] Remove unused variable and fix doc typo (pytorch#…
74d8922 
…136943)

Refactor distributed test code:
- Fix TODO: Remove unused variable
- Fix doc typo
- Migrate deprecated method call `load_state_dict` and `save_state_dict`

Pull Request resolved: pytorch#136943
Approved by: https://github.com/H-Huang
@zeshengzong zeshengzong deleted the opt/distributed/5 branch October 8, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@H-Huang H-Huang H-Huang approved these changes

@fegin fegin Awaiting requested review from fegin

@LucasLLC LucasLLC Awaiting requested review from LucasLLC

@wz337 wz337 Awaiting requested review from wz337

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (fsdp) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zeshengzong @pytorchmergebot @kwen2501 @H-Huang @pytorchbot