Skip to content

Format torch.fx.experimental.symbolic_shapes with PYFMT #136934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang wants to merge 4 commits into from
Closed

Format torch.fx.experimental.symbolic_shapes with PYFMT #136934

ezyang wants to merge 4 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 29, 2024 •
edited
Loading

@ezyang
Update
3562a77 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Sep 29, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136934

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 141 Pending

As of commit 09c1e5e with merge base failed to retrieve merge base, please contact dev infra:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Sep 29, 2024
@ezyang ezyang mentioned this pull request Sep 29, 2024
Closed
@ezyang
Update
bca79f5 
[ghstack-poisoned]
@ezyang ezyang added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Sep 29, 2024
@ezyang
Update
492edb5 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Sep 30, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@ezyang @pytorchmergebot
Format torch.fx.experimental.validator (#136935)
377e4bc 
Signed-off-by: Edward Z. Yang <[email protected]>
Pull Request resolved: #136935
Approved by: https://github.com/Skylion007
ghstack dependencies: #136917, #136934
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@ezyang @pytorchmergebot
Turn on type-checking in torch.fx.experimental.symbolic_shapes (#136972)
3ff2d93 
Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: #136972
Approved by: https://github.com/Skylion007
ghstack dependencies: #136917, #136934, #136935
@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot revert -c no signal -m "need to revert for broken pr"

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: argument -c/--classification: invalid choice: 'no' (choose from 'nosignal', 'ignoredsignal', 'landrace', 'weird', 'ghfirst')

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot revert -c weird -m "merge conflict revert"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Sep 30, 2024
@pytorchmergebot
Revert "Format torch.fx.experimental.validator (#136935)"
c94536a 
This reverts commit 377e4bc.

Reverted #136935 on behalf of https://github.com/ezyang due to merge conflict revert ([comment](#136934 (comment)))
pytorchmergebot added a commit that referenced this pull request Sep 30, 2024
@pytorchmergebot
Revert "Format torch.fx.experimental.symbolic_shapes with PYFMT (#136934
66a269a 
)"

This reverts commit cf1a7ea.

Reverted #136934 on behalf of https://github.com/ezyang due to merge conflict revert ([comment](#136934 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

@ezyang your PR has been successfully reverted.

@ezyang
Update
09c1e5e 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 1, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 1, 2024
@ezyang @pytorchmergebot
Format torch.fx.experimental.validator (#136935)
951af3d 
Signed-off-by: Edward Z. Yang <[email protected]>
Pull Request resolved: #136935
Approved by: https://github.com/Skylion007
ghstack dependencies: #136934
pytorchmergebot pushed a commit that referenced this pull request Oct 1, 2024
@ezyang @pytorchmergebot
Turn on type-checking in torch.fx.experimental.symbolic_shapes (#136972)
cc8f1cd 
Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: #136972
Approved by: https://github.com/Skylion007
ghstack dependencies: #136934, #136935
pytorchmergebot pushed a commit that referenced this pull request Oct 1, 2024
@ezyang @pytorchmergebot
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes (#…
6bd9d37 
…137019)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: #137019
Approved by: https://github.com/Skylion007
ghstack dependencies: #136934, #136935, #136972
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Turn on type-checking in torch.fx.experimental.symbolic_shapes (pytor…
411cb88 
…ch#136972)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: pytorch#136972
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136917, pytorch#136934, pytorch#136935
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@pytorchmergebot @AnantGulati
Revert "Format torch.fx.experimental.validator (pytorch#136935)"
f091a43 
This reverts commit 377e4bc.

Reverted pytorch#136935 on behalf of https://github.com/ezyang due to merge conflict revert ([comment](pytorch#136934 (comment)))
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@pytorchmergebot @AnantGulati
Revert "Format torch.fx.experimental.symbolic_shapes with PYFMT (pyto…
7db7050 
…rch#136934)"

This reverts commit cf1a7ea.

Reverted pytorch#136934 on behalf of https://github.com/ezyang due to merge conflict revert ([comment](pytorch#136934 (comment)))
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Format torch.fx.experimental.symbolic_shapes with PYFMT (pytorch#136934)
13a617e 
Signed-off-by: Edward Z. Yang <[email protected]>
Pull Request resolved: pytorch#136934
Approved by: https://github.com/Skylion007
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Format torch.fx.experimental.validator (pytorch#136935)
cfb787a 
Signed-off-by: Edward Z. Yang <[email protected]>
Pull Request resolved: pytorch#136935
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136934
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Turn on type-checking in torch.fx.experimental.symbolic_shapes (pytor…
33e7cbd 
…ch#136972)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: pytorch#136972
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136934, pytorch#136935
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes (p…
a5e103d 
…ytorch#137019)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: pytorch#137019
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136934, pytorch#136935, pytorch#136972
@github-actions github-actions bot deleted the gh/ezyang/2946/head branch November 3, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @Skylion007