[FlexAttention] Support training bias for eager #136910
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136910
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f50f124 with merge base a408cfc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
yanboliang
commented
Sep 30, 2024
yanboliang
commented
Sep 30, 2024
zou3519
reviewed
Sep 30, 2024
zou3519
reviewed
Sep 30, 2024
zou3519
reviewed
Oct 4, 2024
Chillee
reviewed
Oct 4, 2024
Chillee
approved these changes
Oct 4, 2024
drisspg
added a commit
that referenced
this pull request
Oct 9, 2024
Part 2 of #136910 With some updates from: #137451 And updates to lib name + lazy registration cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
drisspg
added a commit
that referenced
this pull request
Oct 9, 2024
Part 2 of #136910 With some updates from: #137451 And updates to lib name + lazy registration cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
drisspg
added a commit
that referenced
this pull request
Oct 9, 2024
Part 2 of #136910 With some updates from: #137451 And updates to lib name + lazy registration cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
drisspg
added a commit
that referenced
this pull request
Oct 9, 2024
drisspg
added a commit
that referenced
this pull request
Oct 10, 2024
…eager (#136910)" This PR is Part 2 of the implementation started in #136910, rolled in the updates from #137451. Original was reverted due to calls to #torch.libary at `import torch` time, so added a call to register at first call to `ModIndex` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec [ghstack-poisoned]
drisspg
added a commit
that referenced
this pull request
Oct 10, 2024
This PR is Part 2 of the implementation started in #136910, rolled in the updates from #137451. Original was reverted due to calls to #torch.libary at `import torch` time, so added a call to register at first call to `ModIndex` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec [ghstack-poisoned]
drisspg
added a commit
that referenced
this pull request
Oct 10, 2024
drisspg
added a commit
that referenced
this pull request
Oct 12, 2024
drisspg
added a commit
that referenced
this pull request
Oct 15, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 15, 2024
This PR is Part 2 of the implementation started in #136910, rolled in the updates from #137451. Original was reverted due to calls to #@torch.libary at `import torch` time, so added a call to register at first call to `ModIndex` Pull Request resolved: #137526 Approved by: https://github.com/Chillee, https://github.com/zou3519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add training bias eager implementation, take over the original POC from #136076
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang