Download pre-compiled AOTriton from GitHub unless AOTRITON_INSTALL_FROM_SOURCE=1 is set #136786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OM_SOURCE=1 is set (#136603) PyTorch community members have reported issues with building PyTorch from source for ROCm in an environment that doesn't have aotriton pre-installed, because aotriton is only installed in the [CI](https://github.com/pytorch/pytorch/blob/a8ed873ba2aa13437a336863ae9d73c235798acc/.ci/docker/ubuntu-rocm/Dockerfile#L110)/[manywheel](https://github.com/pytorch/pytorch/blob/a8ed873ba2aa13437a336863ae9d73c235798acc/.ci/docker/manywheel/Dockerfile#L197) docker images. Building aotriton from source can take ~45 minutes. This PR fixes the issue by downloading the aotriton tarball in such scenarios, *unless the user explicitly wants to build aotriton from source using the AOTRITON_INSTALL_FROM_SOURCE=1 env var* Pull Request resolved: #136603 Approved by: https://github.com/atalman Co-authored-by: Xinya Zhang <[email protected]> (cherry picked from commit 851b973)
This was referenced Sep 26, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136786
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a0ea924 with merge base b7eb725 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
requested changes
Sep 26, 2024
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
IMO it does not meet any of the existing cherry-pick criteria
Contributor
|
I'm closing this for now as this is not going to be cherry-picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch community members have reported issues with building PyTorch from source for ROCm in an environment that doesn't have aotriton pre-installed, because aotriton is only installed in the CI/manywheel docker images. Building aotriton from source can take ~45 minutes.
This PR fixes the issue by downloading the aotriton tarball in such scenarios, unless the user explicitly wants to build aotriton from source using the AOTRITON_INSTALL_FROM_SOURCE=1 env var