Add generator parameter to rand*_like functions #136780

moltinginstar · 2024-09-26T18:39:17Z

Fixes #128786
Fixes #101974
Fixes #27072

cc @pbelevich

pytorch-bot · 2024-09-26T18:39:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136780

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0e79f18 with merge base 354fe48 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2024-09-26T18:39:21Z

The committers listed above are authorized under a signed CLA.

✅ login: moltinginstar / name: Sam (0e79f18, fff9684, bd298c4)

github-actions · 2024-09-26T18:43:34Z

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

aten/src/ATen/native/native_functions.yaml

moltinginstar · 2024-09-26T18:58:41Z

@pytorchbot label "module: random"

moltinginstar · 2024-09-26T19:06:23Z

@pytorchbot label "release notes: python_frontend"

albanD

Thanks for your contribution. That sounds pretty good.
Would you be able to sign the cla and update testing to ensure these are working as expected?

Chillee · 2024-10-28T09:33:41Z

@pytorchbot rebase

pytorchmergebot · 2024-10-28T09:35:13Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-10-28T09:35:18Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch push -f https://github.com/moltinginstar/pytorch.git pull/136780/head:rand-like-generator-param returned non-zero exit code 1

To https://github.com/moltinginstar/pytorch.git
 ! [remote rejected]       pull/136780/head -> rand-like-generator-param (permission denied)
error: failed to push some refs to 'https://github.com/moltinginstar/pytorch.git'

Raised by https://github.com/pytorch/pytorch/actions/runs/11551143082

moltinginstar · 2024-10-28T11:15:16Z

@pytorchbot rebase

pytorch-bot · 2024-10-28T11:15:20Z

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

ezyang · 2025-01-27T15:49:07Z

I'm working with the internal folks to figure out what exactly went wrong

…)" This reverts commit c7b2f7d. Reverted pytorch#136780 on behalf of https://github.com/izaitsevfb due to internal regression ([comment](pytorch#136780 (comment)))

ezyang · 2025-01-29T18:29:26Z

@pytorchbot merge -r

pytorch-bot · 2025-01-29T18:29:31Z

This PR needs to be approved by an authorized maintainer before merge.

ezyang · 2025-01-30T14:56:39Z

@pytorchbot merge -r

pytorchmergebot · 2025-01-30T14:58:08Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-01-30T14:58:11Z

Successfully rebased rand-like-generator-param onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout rand-like-generator-param && git pull --rebase)

pytorchmergebot · 2025-01-30T14:59:29Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-01-30T14:59:40Z

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

…)" This reverts commit c7b2f7d. Reverted pytorch#136780 on behalf of https://github.com/izaitsevfb due to internal regression ([comment](pytorch#136780 (comment)))

github-actions · 2025-03-31T18:39:53Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

moltinginstar · 2025-04-10T15:24:24Z

Hey @ezyang! Just wanted to check in on this PR. Looks like the merge failed due to something unrelated to my changes—would it be possible to re-trigger it? Let me know if there’s anything I can do to help move it along.

moltinginstar · 2025-05-22T11:59:37Z

Hi @ezyang @Chillee @albanD, following up again. Since this got marked as stale and auto-closed, should I file a fresh PR, or is this feature not a priority right now?

alexander-t-ho · 2025-11-26T02:22:15Z

I’m interested in contributing to PyTorch by implementing the generator parameter for randn_like/rand_like/randint_like . Before I start, I wanted to confirm: 1. Is this still needed? 2. Any preferred implementation approach? 3. Who should review the PR?

KarhouTam · 2025-12-10T07:06:54Z

Hi, @alexander-t-ho. This issue is solved and codes are merged already. Check #166160

pytorchbot added the open source label Sep 26, 2024

pytorch-bot bot added the module: random Related to random number generation in PyTorch (rng generator) label Sep 26, 2024

pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Sep 26, 2024

cpuhrsch requested a review from albanD September 27, 2024 02:22

cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 27, 2024

albanD reviewed Oct 4, 2024

View reviewed changes

moltinginstar force-pushed the rand-like-generator-param branch from d54c129 to 9f3c848 Compare October 5, 2024 06:21

moltinginstar requested a review from albanD October 9, 2024 06:07

Chillee previously approved these changes Oct 26, 2024

View reviewed changes

moltinginstar force-pushed the rand-like-generator-param branch from dcb5f85 to 9074172 Compare December 25, 2024 06:36

moltinginstar requested review from EikanWang, angelayi, avikchaudhuri, eqy, gujinghui, mikaylagawarecki, syed-ahmed, tugsbayasgalan, ydwu4 and zhxchen17 as code owners December 25, 2024 06:36

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jan 24, 2025

pytorchmergebot reopened this Jan 24, 2025

eellison removed their request for review January 30, 2025 02:08

ezyang approved these changes Jan 30, 2025

View reviewed changes

moltinginstar added 3 commits January 30, 2025 14:58

Add generator parameter to rand*_like functions

fff9684

Add unit tests

bd298c4

Fix test failures

0e79f18

pytorchmergebot force-pushed the rand-like-generator-param branch from 882cb31 to 0e79f18 Compare January 30, 2025 14:58

pytorchmergebot added the merging label Jan 30, 2025

pytorchmergebot removed the merging label Jan 30, 2025

github-actions bot added the Stale label Mar 31, 2025

github-actions bot closed this May 10, 2025

Add generator parameter to rand*_like functions #136780

Add generator parameter to rand*_like functions #136780

Uh oh!

Conversation

moltinginstar commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136780

✅ No Failures

Uh oh!

linux-foundation-easycla bot commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 26, 2024

Attention! native_functions.yaml was changed

Uh oh!

moltinginstar commented Sep 26, 2024

Uh oh!

moltinginstar commented Sep 26, 2024

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

Chillee commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

moltinginstar commented Oct 28, 2024

Uh oh!

pytorch-bot bot commented Oct 28, 2024

Uh oh!

ezyang commented Jan 27, 2025

Uh oh!

ezyang commented Jan 29, 2025

Uh oh!

pytorch-bot bot commented Jan 29, 2025

Uh oh!

ezyang commented Jan 30, 2025

Uh oh!

pytorchmergebot commented Jan 30, 2025

Uh oh!

pytorchmergebot commented Jan 30, 2025

Uh oh!

pytorchmergebot commented Jan 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Jan 30, 2025

Merge failed

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

moltinginstar commented Apr 10, 2025

Uh oh!

moltinginstar commented May 22, 2025

Uh oh!

alexander-t-ho commented Nov 26, 2025

Uh oh!

KarhouTam commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

moltinginstar commented Sep 26, 2024 •

edited

Loading

pytorch-bot bot commented Sep 26, 2024 •

edited

Loading

linux-foundation-easycla bot commented Sep 26, 2024 •

edited

Loading