[aoti][inplace] Support skipping model buffers #136770
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136770
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Cancelled Job, 11 Unrelated FailuresAs of commit bb34e17 with merge base a63d7cb ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62777502 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62777502 |
22quinn
force-pushed
the
export-D62777502
branch
from
a86eb50 to
376a3d0
Compare
22quinn
added a commit
to 22quinn/pytorch
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: pytorch#136770 Some AOTI tensor constants may be model buffers that never needs to be updated. Reviewed By: muchulee8 Differential Revision: D62777502
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62777502 |
22quinn
force-pushed
the
export-D62777502
branch
from
376a3d0 to
28cfc77
Compare
22quinn
added a commit
to 22quinn/pytorch
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: pytorch#136770 Some AOTI tensor constants may be model buffers that never needs to be updated. Reviewed By: muchulee8 Differential Revision: D62777502
Summary: Pull Request resolved: pytorch#136770 Some AOTI tensor constants may be model buffers that never needs to be updated. Reviewed By: muchulee8 Differential Revision: D62777502
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62777502 |
22quinn
force-pushed
the
export-D62777502
branch
from
28cfc77 to
bb34e17
Compare
muchulee8
approved these changes
Sep 27, 2024
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
Contributor
Author
|
@pytorchbot merge -f "landed internally" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
Summary: Some AOTI tensor constants may be model buffers that never needs to be updated. Differential Revision: D62777502 Pull Request resolved: pytorch#136770 Approved by: https://github.com/muchulee8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Some AOTI tensor constants may be model buffers that never needs to be updated.
Differential Revision: D62777502
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang