Skip to content

[reland] [torchelastic][c10d] Fix store prefix race in rendezvous #136768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fduwjj wants to merge 1 commit into from
Closed

[reland] [torchelastic][c10d] Fix store prefix race in rendezvous #136768

fduwjj wants to merge 1 commit into from

Conversation

@fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Sep 26, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136768

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit fef6a45 with merge base a0c76ea (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fduwjj added a commit that referenced this pull request Sep 26, 2024
@fduwjj
[reland] [torchelastic][c10d] Fix store prefix race in rendezvous
be34bbb 
ghstack-source-id: 3ec1cf9
Pull Request resolved: #136768
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (torchelastic) labels Sep 26, 2024
@fduwjj fduwjj mentioned this pull request Sep 26, 2024
Closed
@fduwjj
Copy link
Contributor Author

fduwjj commented Sep 26, 2024

this is to reland #135957 as it can not be closed.

kwen2501
kwen2501 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't read the details. Stamping to unblock reland.

@atalman
Copy link
Contributor

atalman commented Sep 26, 2024

@pytorchmergebot merge -f "lint it green CI was already executed on this PR"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 26, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/fduwjj/139/head branch October 27, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (torchelastic)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fduwjj @atalman @pytorchmergebot @kwen2501