Skip to content

enable auto functionalize v2 by default #136685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
laithsakka wants to merge 5 commits into from
Closed

enable auto functionalize v2 by default #136685

laithsakka wants to merge 5 commits into from

Conversation

@laithsakka
Copy link
Contributor

@laithsakka laithsakka commented Sep 25, 2024 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136685

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e42bfb3 with merge base f8a5b71 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

laithsakka added a commit that referenced this pull request Sep 25, 2024
@laithsakka
enable auto functionalize v2 by default
a5c41a6 
ghstack-source-id: d46cd10
Pull Request resolved: #136685
@laithsakka laithsakka requested a review from zou3519 September 25, 2024 22:15
zou3519
zou3519 reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna need some fixes for compiled autograd. Easiest way is probably to have compiled autograd use v1 and we figure out how to migrate it over. Though the fix is not hard, see #135169

@laithsakka
Copy link
Contributor Author

laithsakka commented Sep 26, 2024

Gonna need some fixes for compiled autograd. Easiest way is probably to have compiled autograd use v1 and we figure out how to migrate it over. Though the fix is not hard, see #135169

oh those are new tests. i will take a look

@laithsakka laithsakka added the topic: not user facing topic category label Sep 26, 2024
@laithsakka
Update on "enable auto functionalize v2 by default"
5aef663 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@laithsakka laithsakka mentioned this pull request Sep 26, 2024
Closed
laithsakka added a commit that referenced this pull request Sep 26, 2024
@laithsakka
enable auto functionalize v2 by default
d315235 
ghstack-source-id: d7a85b7
Pull Request resolved: #136685
zou3519
zou3519 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as long as the CI is green

@laithsakka
Update on "enable auto functionalize v2 by default"
8195506 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
laithsakka added a commit that referenced this pull request Oct 10, 2024
@laithsakka
enable auto functionalize v2 by default
e612e52 
ghstack-source-id: c857c96
Pull Request resolved: #136685
@laithsakka
Copy link
Contributor Author

laithsakka commented Oct 10, 2024

rebase on main.

@laithsakka laithsakka mentioned this pull request Oct 11, 2024
Closed
@laithsakka
Update on "enable auto functionalize v2 by default"
65f498a 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@laithsakka
Update on "enable auto functionalize v2 by default"
e42bfb3 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
laithsakka added a commit that referenced this pull request Oct 14, 2024
@laithsakka
enable auto functionalize v2 by default
87ec6a0 
ghstack-source-id: f71f8e7
Pull Request resolved: #136685
@laithsakka
Copy link
Contributor Author

laithsakka commented Oct 15, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 15, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 15, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/laithsakka/73/head branch November 15, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laithsakka @pytorchmergebot @zou3519