Don't generate implicit value ranges for missing symbols. #136667
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136667
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e0ed5b5 with merge base 59cdd8d ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
My first plan is to fix all symbol allocation sites to correctly add value ranges. My second plan is to push it into bound_sympy itself (a default value). Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: b230af7 Pull Request resolved: #136667
My first plan is to fix all symbol allocation sites to correctly add value ranges. My second plan is to push it into bound_sympy itself (a default value). Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: f91a61c Pull Request resolved: #136667
|
@pytorchbot merge -r |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
My first plan is to fix all symbol allocation sites to correctly add value ranges. My second plan is to push it into bound_sympy itself (a default value). Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 61e1130 Pull Request resolved: #136667
|
Successfully rebased |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -f "xla failure is fake" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
Instead, callback to a missing handler when needed. This greatly speeds things up with the value ranges dict is large. The missing handler is needed because nested ints don't have VRs, but symbolic sizes involving them occasionally show up in compute.
Signed-off-by: Edward Z. Yang [email protected]
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10