Skip to content

[ONNX] Remove unused functions #136609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinchuby wants to merge 2 commits into from
Closed

[ONNX] Remove unused functions #136609

justinchuby wants to merge 2 commits into from

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Sep 25, 2024 •
edited
Loading

@justinchuby
Update
ea5c927 
[ghstack-poisoned]
@justinchuby justinchuby mentioned this pull request Sep 25, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136609

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit af0bd31 with merge base 9629835 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 25, 2024
justinchuby added a commit that referenced this pull request Sep 25, 2024
@justinchuby
[ONNX] Remove unused functions
4ae1782 
ghstack-source-id: 0f6b707
Pull Request resolved: #136609
@justinchuby
Update
af0bd31 
[ghstack-poisoned]
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 27, 2024
@justinchuby
[ONNX] Remove unused functions
1ee7e1c 
ghstack-source-id: 58055ff
Pull Request resolved: pytorch#136609
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: not user facing topic category labels Sep 27, 2024
@justinchuby
Copy link
Collaborator Author

justinchuby commented Sep 27, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 27, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 27, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 27, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@justinchuby
Copy link
Collaborator Author

justinchuby commented Sep 27, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 27, 2024

Merge started

Your change will be merged while ignoring the following 4 checks: pull / linux-focal-py3.12-clang10 / test (default, 3, 4, lf.linux.2xlarge), pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge), pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 3, 3, linux.2xlarge), pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 3, 3, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/justinchuby/105/head branch October 28, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@titaiwangms titaiwangms Awaiting requested review from titaiwangms

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @pytorchmergebot @Skylion007 @pytorchbot