Skip to content

[Inductor UT] Generalize device-bias code introduced from #134874 and #136596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
etaf wants to merge 5 commits into from
Closed

[Inductor UT] Generalize device-bias code introduced from #134874 and #136596

etaf wants to merge 5 commits into from

Conversation

@etaf
Copy link
Collaborator

@etaf etaf commented Sep 25, 2024 •
edited
Loading

@etaf
Update
4be62ce 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136596

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit f4531b2 with merge base a0c76ea (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@etaf etaf added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 25, 2024
@etaf
Copy link
Collaborator Author

etaf commented Sep 25, 2024

Current ciflow/xpu is blocked by the fix of #136280

@etaf etaf added the ciflow/xpu Run XPU CI tasks label Sep 25, 2024
@etaf etaf requested a review from EikanWang September 25, 2024 01:54
This was referenced Sep 25, 2024
Closed
Closed
@EikanWang
Copy link
Collaborator

EikanWang commented Sep 25, 2024

@pytorchbot rebase

@etaf
Copy link
Collaborator Author

etaf commented Sep 25, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 25, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 25, 2024

Tried to rebase and push PR #136596, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 25, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 25, 2024

Successfully rebased gh/etaf/46/orig onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/136596)

guangyey and others added 3 commits September 25, 2024 10:15
@guangyey
Update
0aafa0d 
[ghstack-poisoned]
@etaf
Update
a08727f 
[ghstack-poisoned]
@etaf
Update
3b2a906 
[ghstack-poisoned]
@etaf
Update
f4531b2 
[ghstack-poisoned]
etaf added a commit that referenced this pull request Sep 25, 2024
@etaf
[Inductor UT] Generalize device-bias code introduced from #134874 and
35c1c61 
fix an unexpected success test case.

ghstack-source-id: 523ef6a
Pull Request resolved: #136596
@etaf etaf requested a review from eellison September 26, 2024 01:32
@etaf etaf requested a review from peterbell10 September 26, 2024 01:32
@etaf
Copy link
Collaborator Author

etaf commented Sep 26, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 26, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/etaf/46/head branch October 27, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@EikanWang EikanWang EikanWang approved these changes

@desertfire desertfire Awaiting requested review from desertfire

@eellison eellison Awaiting requested review from eellison

@peterbell10 peterbell10 Awaiting requested review from peterbell10

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: inductor open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@etaf @EikanWang @pytorchmergebot @jansel @pytorchbot @guangyey