[export] fix _get_non_persistent_buffers for duplicates #136552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

pianpwk wants to merge 1 commit into main from export-D63332976

Contributor

pianpwk commented Sep 24, 2024

Summary: Export's method _get_non_persistent_buffers doesn't check duplicate submodules, so we run into state_dict related issues if non-persistent buffers exist on shared submodules.

Test Plan: test_export

Differential Revision: D63332976

pianpwk requested review from angelayi, avikchaudhuri, tugsbayasgalan, ydwu4 and zhxchen17 as code owners

September 24, 2024 18:05

pytorch-bot bot commented Sep 24, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136552

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a90f131 with merge base 95c0f74 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 5, 5, lf.linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
'test/inductor/test_cudacodecache.py::TestCUDACodeCache::test_cuda_load'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63332976

facebook-github-bot added the fb-exported label

pianpwk added the release notes: export label

facebook-github-bot force-pushed the export-D63332976 branch from e663a61 to 7545237 Compare

September 24, 2024 18:49

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63332976

1 similar comment

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63332976

pianpwk force-pushed the export-D63332976 branch from 7545237 to 09cd257 Compare

September 24, 2024 18:51

avikchaudhuri approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

tugsbayasgalan approved these changes

View reviewed changes

pianpwk force-pushed the export-D63332976 branch from 09cd257 to db7c1ba Compare

September 24, 2024 20:27

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63332976


          [export] fix _get_non_persistent_buffers for duplicates (#136552)

a90f131

Summary:
Pull Request resolved: #136552

Export's method _get_non_persistent_buffers doesn't check duplicate submodules, so we run into state_dict related issues if non-persistent buffers exist on shared submodules.

Test Plan: test_export

Reviewed By: avikchaudhuri, tugsbayasgalan

Differential Revision: D63332976

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63332976

pianpwk force-pushed the export-D63332976 branch from db7c1ba to a90f131 Compare

September 24, 2024 21:19

Contributor

facebook-github-bot commented Sep 25, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Sep 25, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

7c6d543

pytorchmergebot removed the merging label

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request


          [export] fix _get_non_persistent_buffers for duplicates (pytorch#136552)

Summary: Export's method _get_non_persistent_buffers doesn't check duplicate submodules, so we run into state_dict related issues if non-persistent buffers exist on shared submodules.

Test Plan: test_export

Differential Revision: D63332976

Pull Request resolved: pytorch#136552
Approved by: https://github.com/avikchaudhuri, https://github.com/tugsbayasgalan

github-actions bot deleted the export-D63332976 branch

October 27, 2024 02:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

avikchaudhuri avikchaudhuri approved these changes

tugsbayasgalan tugsbayasgalan approved these changes

zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

angelayi Awaiting requested review from angelayi angelayi is a code owner

Labels

ciflow/trunk fb-exported Merged release notes: export