[AOTI] Turn on the ABI-compatible mode as default #136534
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136534
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3b0e001 with merge base f69bf00 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Make AOTI generate ABI-compatible code as default for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: Make AOTI generate ABI-compatible code as default for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: Make AOTI generate ABI-compatible code as default for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: Make AOTI generate ABI-compatible code as default for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: Make AOTI generate ABI-compatible code as default for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: Make AOTI generate ABI-compatible code as default for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
This was referenced Oct 2, 2024
Summary: Make AOTI generate ABI-compatible code as default for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: Make AOTI generate ABI-compatible code as default for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: Make AOTI generate ABI-compatible code as default for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang rec [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
desertfire
added a commit
that referenced
this pull request
Oct 15, 2024
Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 15, 2024
…ible mode" Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 15, 2024
Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 15, 2024
…ible mode" Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 15, 2024
Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 16, 2024
…ible mode" Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang Differential Revision: [D64439676](https://our.internmc.facebook.com/intern/diff/D64439676) [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 16, 2024
Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang Differential Revision: [D64439676](https://our.internmc.facebook.com/intern/diff/D64439676) [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 16, 2024
…ible mode" Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang Differential Revision: [D64439676](https://our.internmc.facebook.com/intern/diff/D64439676) [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Oct 16, 2024
Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang Differential Revision: [D64439676](https://our.internmc.facebook.com/intern/diff/D64439676) [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 17, 2024
Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic. Differential Revision: [D64439676](https://our.internmc.facebook.com/intern/diff/D64439676) Pull Request resolved: #138009 Approved by: https://github.com/chenyang78 ghstack dependencies: #137982, #138016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Make AOTI generate ABI-compatible code as default for OSS.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang @rec