Don't try to evaluate sympy.Eq in replacement; we knew this wouldn't simplify since we are here #136533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136533
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1fb54a0 with merge base 44ec706 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Sep 24, 2024
…simplify since we are here Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 4f42ab4 Pull Request resolved: #136533
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
isuruf
approved these changes
Sep 24, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: Approvers from one of the following sets are needed:
|
pianpwk
approved these changes
Sep 24, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 25, 2024
…6508) Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #136508 Approved by: https://github.com/zou3519, https://github.com/bdhirsh, https://github.com/malfet ghstack dependencies: #136533
PaliC
pushed a commit
to PaliC/pytorch
that referenced
this pull request
Sep 25, 2024
…simplify since we are here (pytorch#136533) Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#136533 Approved by: https://github.com/isuruf, https://github.com/pianpwk
BoyuanFeng
pushed a commit
to BoyuanFeng/pytorch
that referenced
this pull request
Sep 25, 2024
…simplify since we are here (pytorch#136533) Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#136533 Approved by: https://github.com/isuruf, https://github.com/pianpwk
BoyuanFeng
pushed a commit
to BoyuanFeng/pytorch
that referenced
this pull request
Sep 25, 2024
…orch#136508) Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#136508 Approved by: https://github.com/zou3519, https://github.com/bdhirsh, https://github.com/malfet ghstack dependencies: pytorch#136533
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #136767 Approved by: https://github.com/albanD, https://github.com/jansel ghstack dependencies: #136533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang [email protected]