Skip to content

fix the inductor tests #136474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xuanzhang816 wants to merge 1 commit into from
Closed

fix the inductor tests #136474

xuanzhang816 wants to merge 1 commit into from

Conversation

@xuanzhang816
Copy link
Contributor

@xuanzhang816 xuanzhang816 commented Sep 23, 2024

Fixes #136464 introduced in #134874

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136474

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6400f0d with merge base 52c917b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuanzhang816 xuanzhang816 marked this pull request as ready for review September 23, 2024 21:52
@xuanzhang816 xuanzhang816 requested a review from a team as a code owner September 23, 2024 21:52
@xuanzhang816
Copy link
Contributor Author

xuanzhang816 commented Sep 23, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 23, 2024
@xuanzhang816 xuanzhang816 requested a review from albanD September 23, 2024 21:58
@xuanzhang816 xuanzhang816 mentioned this pull request Sep 23, 2024
Closed
malfet
malfet approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@malfet malfet added the ciflow/linux-aarch64 linux aarch64 CI workflow label Sep 23, 2024
@malfet
Copy link
Contributor

malfet commented Sep 23, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 23, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 23, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuanzhang816
Copy link
Contributor Author

xuanzhang816 commented Sep 23, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 23, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 23, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Sep 24, 2024

@pytorchbot merge -f "Don't want to wait for ROCM builds"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@xuanzhang816 @BoyuanFeng
fix the inductor tests (pytorch#136474)
5c75804 
Fixes pytorch#136464 introduced in pytorch#134874

Pull Request resolved: pytorch#136474
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@yf225 yf225 Awaiting requested review from yf225

@eellison eellison Awaiting requested review from eellison

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New test added inductor/test_memory not called correctly, breaks linux-aarch64 ciflow

3 participants

@xuanzhang816 @malfet @pytorchmergebot