[test only] repro thousand separators in generated cuda code #136459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test script:
```python
import locale
locale.setlocale(locale.LC_ALL, "")
print(f"{1234:n}")
import torch
print(f"{1234:n}")
locale.setlocale(locale.LC_ALL, "")
print(f"{1234:n}")
def fn(x, y):
return (x + y) * 3249
x, y = (torch.randn(33, 123123,
device="cuda").mul(100).to(torch.int32) for _ in range(2))
fn(x, y)
fn_s = torch.jit.script(fn)
for _ in range(4):
fn_s(x, y)
print(f"{1234:n}")
```
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136459
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0597bd5 with merge base 663e760 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
test script:
```python
import locale
locale.setlocale(locale.LC_ALL, "")
print(f"{1234:n}")
import torch
print(f"{1234:n}")
locale.setlocale(locale.LC_ALL, "")
print(f"{1234:n}")
def fn(x, y):
return (x + y) * 3249
x, y = (torch.randn(33, 123123,
device="cuda").mul(100).to(torch.int32) for _ in range(2))
fn(x, y)
fn_s = torch.jit.script(fn)
for _ in range(4):
fn_s(x, y)
print(f"{1234:n}")
```
cc EikanWang jgong5
[ghstack-poisoned]
davidberard98
added a commit
that referenced
this pull request
Sep 23, 2024
test script:
```python
import locale
locale.setlocale(locale.LC_ALL, "")
print(f"{1234:n}")
import torch
print(f"{1234:n}")
locale.setlocale(locale.LC_ALL, "")
print(f"{1234:n}")
def fn(x, y):
return (x + y) * 3249
x, y = (torch.randn(33, 123123,
device="cuda").mul(100).to(torch.int32) for _ in range(2))
fn(x, y)
fn_s = torch.jit.script(fn)
for _ in range(4):
fn_s(x, y)
print(f"{1234:n}")
```
ghstack-source-id: 6c23b15
Pull Request resolved: #136459
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 24, 2024
We had an internal report where the NNC-generated CUDA code had thousands separators in integer literals. Although I wasn't able to cleanly repro, I did come up with a hacky repro and verified that this fix works (see #136459). Differential Revision: [D63278771](https://our.internmc.facebook.com/intern/diff/D63278771) Pull Request resolved: #136458 Approved by: https://github.com/eellison
BoyuanFeng
pushed a commit
to BoyuanFeng/pytorch
that referenced
this pull request
Sep 25, 2024
We had an internal report where the NNC-generated CUDA code had thousands separators in integer literals. Although I wasn't able to cleanly repro, I did come up with a hacky repro and verified that this fix works (see pytorch#136459). Differential Revision: [D63278771](https://our.internmc.facebook.com/intern/diff/D63278771) Pull Request resolved: pytorch#136458 Approved by: https://github.com/eellison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
test script:
cc @EikanWang @jgong5