-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[inductor] [cpp] fix gemm_output_name conflict #136419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136419
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e31d24e with merge base e9bfbf7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
Fixes the max-autotune failure of
soft_actor_criticof Torchbench in FP32 single thread dynamic shape case:The 1st and 2nd linear does not need to use local buffer while the 3rd linear needs to use local buffer.
The 3rd linear which uses local buffer will add its global buffer (named as
buf_GemmOut) intoV.graph.removed_buffers.When scheduling the nodes, the 1st linear (won't use local buffer) will get its output buffer (also named as
buf_GemmOut) from the input and found that it's in theV.graph.removed_buffersand raise AssertionError. The issue is that the output buffer of all these linears are all names withbuf_GemmOut, which have a conflict.Rename these buffers by adding the name of the
template_bufferas the prefix.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang