Skip to content

Ensure noncontiguous tensor creation tests offsetting #136396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benjaminglass1 wants to merge 14 commits into from
Closed

Ensure noncontiguous tensor creation tests offsetting #136396

benjaminglass1 wants to merge 14 commits into from

Conversation

@benjaminglass1
Copy link
Collaborator

@benjaminglass1 benjaminglass1 commented Sep 21, 2024 •
edited
Loading

@benjaminglass1
Update
dd75b6a 
[ghstack-poisoned]
This was referenced Sep 21, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136396

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 07cd895 with merge base 8f4f7be (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@benjaminglass1
Update
f3d09ef 
[ghstack-poisoned]
@benjaminglass1
Update
b30a636 
[ghstack-poisoned]
@benjaminglass1
Update
07da64b 
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Sep 21, 2024
@benjaminglass1
Ensure noncontiguous tensor creation tests offsetting
b3ec0f4 
ghstack-source-id: 545c6c1
Pull Request resolved: #136396
@benjaminglass1 benjaminglass1 added keep-going Don't stop on first failure, keep running tests until the end ciflow/trunk Trigger trunk jobs on your pull request labels Sep 24, 2024
@benjaminglass1
Update
bbbf664 
[ghstack-poisoned]
@benjaminglass1 benjaminglass1 self-assigned this Sep 24, 2024
@benjaminglass1
Update
1227da3 
[ghstack-poisoned]
@benjaminglass1 benjaminglass1 removed the keep-going Don't stop on first failure, keep running tests until the end label Sep 24, 2024
benjaminglass1 added a commit that referenced this pull request Sep 24, 2024
@benjaminglass1
Ensure noncontiguous tensor creation tests offsetting
6ceb562 
ghstack-source-id: 6d232ad
Pull Request resolved: #136396
@benjaminglass1 benjaminglass1 removed the ciflow/trunk Trigger trunk jobs on your pull request label Sep 24, 2024
@benjaminglass1
Update
c31bdf5 
[ghstack-poisoned]
@benjaminglass1
Update
fec5c4d 
[ghstack-poisoned]
@benjaminglass1
Update
06a3af7 
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Sep 25, 2024
@benjaminglass1
Ensure noncontiguous tensor creation tests offsetting
10509e9 
ghstack-source-id: c9b206f
Pull Request resolved: #136396
@benjaminglass1
Update
3910dcd 
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Sep 27, 2024
@benjaminglass1
Ensure noncontiguous tensor creation tests offsetting
774beba 
ghstack-source-id: 081697c
Pull Request resolved: #136396
@benjaminglass1 benjaminglass1 added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 27, 2024
@benjaminglass1
Update
26d3de7 
[ghstack-poisoned]
@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Sep 28, 2024

Shuffled the stack to put the lowering for searchsorted last, since that'll likely take longer to merge.

amjames
amjames approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@amjames amjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amjames amjames requested review from eellison and jgong5 October 1, 2024 15:32
@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Oct 1, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Oct 1, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, lf.linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@davidberard98
Copy link
Contributor

davidberard98 commented Oct 2, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@benjaminglass1 @AnantGulati
Ensure noncontiguous tensor creation tests offsetting (pytorch#136396)
9b28f5d 
Pull Request resolved: pytorch#136396
Approved by: https://github.com/amjames, https://github.com/eellison
ghstack dependencies: pytorch#136055
@github-actions github-actions bot deleted the gh/benjaminglass1/10/head branch November 6, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amjames amjames amjames approved these changes

@eellison eellison eellison approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@jgong5 jgong5 Awaiting requested review from jgong5

Assignees

@benjaminglass1 benjaminglass1

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: tests Issues related to tests (not the torch.testing module) open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@benjaminglass1 @pytorchmergebot @davidberard98 @amjames @eellison @pytorchbot