[ONNX] Remove the operators test #136335

justinchuby · 2024-09-19T21:45:59Z

Stack from ghstack (oldest at bottom):

-> [ONNX] Remove the operators test #136335

The tests are obsolete and hard to maintain.

cc @albanD

[ghstack-poisoned]

pytorch-bot · 2024-09-19T21:46:03Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136335

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (19 Unrelated Failures)

As of commit cdd3f8e with merge base 9409274 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-test / test (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 1, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 4, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 5, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, lf.linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, lf.linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 4, 5, lf.linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-py3.9-clang10 / test (crossref, 1, 2, lf.linux.2xlarge) (gh) (detected as infra flaky with no log or failing log classifier)
trunk / linux-focal-cuda11.8-py3.10-gcc9-experimental-split-build-test / test (distributed, 1, 3, lf.linux.8xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 3, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 4, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (jit_legacy, 1, 1, lf.linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_AVX512, 2, 2, lf.linux.2xlarge) (gh) (detected as infra flaky with no log or failing log classifier)
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_NO_AVX2, 2, 2, lf.linux.2xlarge) (gh) (detected as infra flaky with no log or failing log classifier)
trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh) (detected as infra flaky with no log or failing log classifier)
trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) (gh) (detected as infra flaky with no log or failing log classifier)

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-py3.9-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge) (gh) (trunk failure)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

The tests are obsolete and hard to maintain. [ghstack-poisoned]

ghstack-source-id: 1ad07f1 Pull Request resolved: pytorch#136335

The tests are obsolete and hard to maintain. [ghstack-poisoned]

ghstack-source-id: 87e6fd8 Pull Request resolved: pytorch#136335

The tests are obsolete and hard to maintain. [ghstack-poisoned]

ghstack-source-id: 13d7844 Pull Request resolved: pytorch#136335

[ghstack-poisoned]

justinchuby · 2024-09-24T23:06:51Z

@pytorchbot merge -f "rebased so skipping the tests. Previously all passed and this PR is just removing a test file."

pytorchmergebot · 2024-09-24T23:08:39Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ezyang · 2024-09-25T14:02:12Z

@pytorchbot revert -c weird -m "I'll reland this, bear with me"

pytorchmergebot · 2024-09-25T14:05:55Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-09-25T14:06:05Z

@justinchuby your PR has been successfully reverted.

This reverts commit 9629835. Reverted #136335 on behalf of https://github.com/ezyang due to I'll reland this, bear with me ([comment](#136335 (comment)))

[ghstack-poisoned]

ghstack-source-id: d45cc95 Pull Request resolved: #136335

ezyang · 2024-09-25T17:42:25Z

@pytorchbot merge -f "relanding it was safe"

pytorchmergebot · 2024-09-25T17:44:07Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

The tests are obsolete and hard to maintain. Pull Request resolved: pytorch#136335 Approved by: https://github.com/xadupre

This reverts commit 9629835. Reverted pytorch#136335 on behalf of https://github.com/ezyang due to I'll reland this, bear with me ([comment](pytorch#136335 (comment)))

The tests are obsolete and hard to maintain. Pull Request resolved: pytorch#136335 Approved by: https://github.com/xadupre, https://github.com/cyyever Co-authored-by: Edward Z. Yang <[email protected]>

[ONNX] Remove the operators test

8cb20f0

[ghstack-poisoned]

justinchuby requested review from shubhambhokare1, titaiwangms and wschin as code owners September 19, 2024 21:46

This was referenced Sep 19, 2024

[ONNX] Unify ONNXProgram and remove the old one #136281

Closed

[ONNX] Remove _optimize_graph from public init #136279

Closed

pytorch-bot bot added the topic: not user facing topic category label Sep 19, 2024

justinchuby mentioned this pull request Sep 19, 2024

[ONNX] Remove deprecated OperatorExportTypes and ExportTypes #136277

Closed

pytorchbot added the open source label Sep 19, 2024

Update on "[ONNX] Remove the operators test"

4724bf5

The tests are obsolete and hard to maintain. [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 20, 2024

[ONNX] Remove the operators test

20c517b

ghstack-source-id: 1ad07f1 Pull Request resolved: pytorch#136335

Update on "[ONNX] Remove the operators test"

530ed75

The tests are obsolete and hard to maintain. [ghstack-poisoned]

Update on "[ONNX] Remove the operators test"

2cafa9b

The tests are obsolete and hard to maintain. [ghstack-poisoned]

Update on "[ONNX] Remove the operators test"

1e91481

The tests are obsolete and hard to maintain. [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 23, 2024

[ONNX] Remove the operators test

29af12f

ghstack-source-id: 87e6fd8 Pull Request resolved: pytorch#136335

xadupre approved these changes Sep 24, 2024

View reviewed changes

justinchuby added the module: onnx Related to torch.onnx label Sep 24, 2024

Update on "[ONNX] Remove the operators test"

9366213

The tests are obsolete and hard to maintain. [ghstack-poisoned]

justinchuby added 2 commits September 24, 2024 11:08

Update on "[ONNX] Remove the operators test"

d68d703

The tests are obsolete and hard to maintain. [ghstack-poisoned]

Update on "[ONNX] Remove the operators test"

fbab11c

The tests are obsolete and hard to maintain. [ghstack-poisoned]

justinchuby added 2 commits September 24, 2024 11:42

Update on "[ONNX] Remove the operators test"

c1d9fe4

The tests are obsolete and hard to maintain. [ghstack-poisoned]

Update on "[ONNX] Remove the operators test"

2e123fc

The tests are obsolete and hard to maintain. [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 24, 2024

[ONNX] Remove the operators test

78d2c56

ghstack-source-id: 13d7844 Pull Request resolved: pytorch#136335

justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 24, 2024

pytorchmergebot removed the merging label Sep 24, 2024

Update

340c2e0

[ghstack-poisoned]

pytorchmergebot added the merging label Sep 24, 2024

pytorchmergebot closed this in 9629835 Sep 24, 2024

pytorchmergebot added Merged and removed merging labels Sep 24, 2024

pytorchmergebot added the Reverted label Sep 25, 2024

pytorchmergebot reopened this Sep 25, 2024

cyyever approved these changes Sep 25, 2024

View reviewed changes

Update

cdd3f8e

[ghstack-poisoned]

ezyang pushed a commit that referenced this pull request Sep 25, 2024

[ONNX] Remove the operators test

27302b1

ghstack-source-id: d45cc95 Pull Request resolved: #136335

pytorchmergebot added the merging label Sep 25, 2024

pytorchmergebot closed this in 8582835 Sep 25, 2024

pytorchmergebot removed the merging label Sep 25, 2024

github-actions bot deleted the gh/justinchuby/104/head branch October 27, 2024 02:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ONNX] Remove the operators test #136335

[ONNX] Remove the operators test #136335

Uh oh!

justinchuby commented Sep 19, 2024 •

edited by ezyang

Loading

Uh oh!

pytorch-bot bot commented Sep 19, 2024 •

edited

Loading

Uh oh!

justinchuby commented Sep 24, 2024

Uh oh!

pytorchmergebot commented Sep 24, 2024

Uh oh!

ezyang commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Uh oh!

ezyang commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[ONNX] Remove the operators test #136335

[ONNX] Remove the operators test #136335

Uh oh!

Conversation

justinchuby commented Sep 19, 2024 • edited by ezyang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136335

✅ You can merge normally! (19 Unrelated Failures)

Uh oh!

justinchuby commented Sep 24, 2024

Uh oh!

pytorchmergebot commented Sep 24, 2024

Merge started

Uh oh!

ezyang commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Uh oh!

ezyang commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

justinchuby commented Sep 19, 2024 •

edited by ezyang

Loading

pytorch-bot bot commented Sep 19, 2024 •

edited

Loading