Fix and improvements to toward 3.13t #136319

albanD · 2024-09-19T16:35:33Z

Small part of #130689

pytorch-bot · 2024-09-19T16:35:37Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136319

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 14 Unrelated Failures

As of commit fa48e54 with merge base c8d152c ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, lf.linux.g5.4xlarge.nvidia.gpu) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.11-clang10 / test (default, 3, 4, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.11-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.12-clang10 / test (default, 3, 4, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 3, 3, linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 3, 3, linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.9-clang10 / test (crossref, 2, 2, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.9-clang10 / test (default, 3, 4, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.9-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-jammy-py3.9-gcc11 / test (default, 3, 4, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 2, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (similar failure)
'test/profiler/test_cpp_thread.py::CppThreadTest::test_profile_memory'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet

LGTM

facebook-github-bot · 2024-09-19T16:38:56Z

@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Skylion007 · 2024-09-19T16:46:03Z

pybind11 changes look good on my end

albanD · 2024-09-19T19:13:27Z

@pytorchbot merge

pytorchmergebot · 2024-09-19T19:15:23Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-19T19:20:52Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-clang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

albanD · 2024-09-19T20:57:51Z

@pytorchbot merge

pytorchmergebot · 2024-09-19T20:59:37Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-19T21:26:11Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-jammy-py3.9-gcc11 / test (default, 3, 4, lf.linux.2xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

albanD · 2024-09-19T23:26:00Z

@pytorchbot merge

pytorchmergebot · 2024-09-19T23:27:45Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-19T23:28:01Z

Merge failed

Reason: 13 mandatory check(s) failed. The first few are:

pull / linux-focal-py3.12-clang10 / test (default, 3, 4, lf.linux.2xlarge)
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge)
pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 3, 3, linux.2xlarge)
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 3, 3, linux.2xlarge)
pull / linux-jammy-py3.9-gcc11 / test (default, 3, 4, lf.linux.2xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

albanD · 2024-09-19T23:29:04Z

@pytorchbot merge -i

ignore spurious test_segfault test

pytorchmergebot · 2024-09-19T23:31:01Z

Merge started

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-19T23:31:15Z

Merge failed

Reason: 13 mandatory check(s) failed. The first few are:

pull / linux-focal-py3.12-clang10 / test (default, 3, 4, lf.linux.2xlarge)
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge)
pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 3, 3, linux.2xlarge)
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 3, 3, linux.2xlarge)
pull / linux-jammy-py3.9-gcc11 / test (default, 3, 4, lf.linux.2xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

albanD · 2024-09-20T04:19:41Z

@pytorchbot merge -f -m "All failures are detected as flaky"

pytorch-bot · 2024-09-20T04:19:43Z

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

albanD · 2024-09-20T04:20:07Z

@pytorchbot merge -f "All failures are detected as flaky"

pytorchmergebot · 2024-09-20T04:21:59Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Small part of pytorch#130689 Pull Request resolved: pytorch#136319 Approved by: https://github.com/malfet, https://github.com/Skylion007

albanD added 2 commits September 18, 2024 16:50

Fix refcount and ressurect issues with 3.13

be178b1

Introduce pybind guard and first use of it

067aecd

albanD requested review from mikaylagawarecki and soulitzer as code owners September 19, 2024 16:35

pytorch-bot bot added the release notes: jit release notes category label Sep 19, 2024

malfet approved these changes Sep 19, 2024

View reviewed changes

Skylion007 approved these changes Sep 19, 2024

View reviewed changes

lint

243c3c4

albanD added topic: not user facing topic category and removed release notes: jit release notes category labels Sep 19, 2024

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 19, 2024

pytorchmergebot added the merging label Sep 19, 2024

pytorchmergebot removed the merging label Sep 19, 2024

lint again

fa48e54

pytorchmergebot added the merging label Sep 19, 2024

pytorchmergebot removed the merging label Sep 19, 2024

pytorchmergebot added the merging label Sep 19, 2024

pytorchmergebot removed the merging label Sep 19, 2024

pytorchmergebot added the merging label Sep 19, 2024

pytorchmergebot removed the merging label Sep 19, 2024

pytorchmergebot added the merging label Sep 20, 2024

pytorchmergebot added the Merged label Sep 20, 2024

pytorchmergebot closed this in cf31724 Sep 20, 2024

pytorchmergebot removed the merging label Sep 20, 2024

albanD mentioned this pull request Oct 18, 2024

[v.2.5.0] Release Tracker #135522

Closed

Fix and improvements to toward 3.13t #136319

Fix and improvements to toward 3.13t #136319

Uh oh!

Conversation

albanD commented Sep 19, 2024

Uh oh!

pytorch-bot bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136319

⏳ 1 Pending, 14 Unrelated Failures

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 19, 2024

Uh oh!

Skylion007 commented Sep 19, 2024

Uh oh!

albanD commented Sep 19, 2024

Uh oh!

pytorchmergebot commented Sep 19, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 19, 2024

Merge failed

Uh oh!

albanD commented Sep 19, 2024

Uh oh!

pytorchmergebot commented Sep 19, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 19, 2024

Merge failed

Uh oh!

albanD commented Sep 19, 2024

Uh oh!

pytorchmergebot commented Sep 19, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 19, 2024

Merge failed

Uh oh!

albanD commented Sep 19, 2024

Uh oh!

pytorchmergebot commented Sep 19, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 19, 2024

Merge failed

Uh oh!

albanD commented Sep 20, 2024

Uh oh!

pytorch-bot bot commented Sep 20, 2024

Uh oh!

albanD commented Sep 20, 2024

Uh oh!

pytorchmergebot commented Sep 20, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pytorch-bot bot commented Sep 19, 2024 •

edited

Loading