Skip to content

[ONNX] Remove _optimize_graph from public init #136279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinchuby wants to merge 18 commits into from
Closed

[ONNX] Remove _optimize_graph from public init #136279

justinchuby wants to merge 18 commits into from

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Sep 18, 2024 •
edited
Loading

@justinchuby justinchuby mentioned this pull request Sep 18, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136279

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cfb03f9 with merge base 9abdc62 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 18, 2024
justinchuby added a commit that referenced this pull request Sep 18, 2024
@justinchuby
[ONNX] Remove _optimize_graph from public init
9eee85a 
ghstack-source-id: 0e16193
Pull Request resolved: #136279
@justinchuby justinchuby mentioned this pull request Sep 18, 2024
Closed
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 18, 2024
@justinchuby
[ONNX] Remove _optimize_graph from public init
e85c610 
ghstack-source-id: a7d473b
Pull Request resolved: pytorch#136279
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 19, 2024
@justinchuby
[ONNX] Remove _optimize_graph from public init
8eb250a 
ghstack-source-id: 348a304
Pull Request resolved: pytorch#136279
@justinchuby justinchuby mentioned this pull request Sep 19, 2024
Closed
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 20, 2024
@justinchuby
[ONNX] Remove _optimize_graph from public init
e836619 
ghstack-source-id: 0d99f80
Pull Request resolved: pytorch#136279
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 23, 2024
@justinchuby
[ONNX] Remove _optimize_graph from public init
1976c84 
ghstack-source-id: e2b220e
Pull Request resolved: pytorch#136279
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 24, 2024
@justinchuby
[ONNX] Remove _optimize_graph from public init
75f069f 
ghstack-source-id: c5cf3fe
Pull Request resolved: pytorch#136279
@justinchuby
Copy link
Collaborator Author

justinchuby commented Sep 24, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 24, 2024
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: bc breaking topic category labels Sep 24, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby
Copy link
Collaborator Author

justinchuby commented Sep 24, 2024

@pytorchbot merge -f "all pull checks passed "

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@justinchuby @BoyuanFeng
[ONNX] Remove _optimize_graph from public init (pytorch#136279)
e80c885 
Pull Request resolved: pytorch#136279
Approved by: https://github.com/xadupre
ghstack dependencies: pytorch#136281
@github-actions github-actions bot deleted the gh/justinchuby/102/head branch October 25, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms Awaiting requested review from titaiwangms

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

1 more reviewer

@xadupre xadupre xadupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @pytorchmergebot @xadupre @pytorchbot