Skip to content

[ONNX] Remove deprecated OperatorExportTypes and ExportTypes #136277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinchuby wants to merge 24 commits into from
Closed

[ONNX] Remove deprecated OperatorExportTypes and ExportTypes #136277

justinchuby wants to merge 24 commits into from

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Sep 18, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Changes

  • Remove export_to_pretty_string
  • Remove OperatorExportTypes and ExportTypes and all usages
  • Remove _exporter_states
  • Remove the unused assertExpectedONNXGraph in jit_utils

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136277

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 51 Cancelled Jobs

As of commit e39a0b7 with merge base 9629835 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 18, 2024
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: bc breaking topic category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) labels Sep 18, 2024
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
781ca4b 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove the Expect tests.
- Remove _exporter_states


[ghstack-poisoned]
@justinchuby justinchuby mentioned this pull request Sep 18, 2024
Closed
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 18, 2024
@justinchuby
[ONNX] Remove deprecated OperatorExportTypes and ExportTypes
db630b0 
ghstack-source-id: 8d8114e
Pull Request resolved: pytorch#136277

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby mentioned this pull request Sep 18, 2024
Closed
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
4c97b49 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove the Expect tests.
- Remove _exporter_states


[ghstack-poisoned]
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
fd83249 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove the Expect tests.
- Remove _exporter_states


[ghstack-poisoned]
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
fe7b112 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove the Expect tests.
- Remove _exporter_states


[ghstack-poisoned]
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
b5d3eba 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove the Expect tests.
- Remove _exporter_states


[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Sep 18, 2024
@justinchuby
[ONNX] Remove deprecated OperatorExportTypes and ExportTypes
b05d227 
ghstack-source-id: 4ee51b2
Pull Request resolved: #136277

Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
bad5d07 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove the Expect tests.
- Remove _exporter_states


[ghstack-poisoned]
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
5484d35 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove the Expect tests.
- Remove _exporter_states


[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Sep 19, 2024
@justinchuby
[ONNX] Remove deprecated OperatorExportTypes and ExportTypes
372a29c 
ghstack-source-id: 0115ec4
Pull Request resolved: #136277

Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
90941f6 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove the Expect tests.
- Remove _exporter_states


[ghstack-poisoned]
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
b24eb4f 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove the Expect tests.
- Remove _exporter_states


[ghstack-poisoned]
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
4bc3e5a 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove _exporter_states


[ghstack-poisoned]
@justinchuby
Update on "[ONNX] Remove deprecated OperatorExportTypes and ExportTypes"
b69d33e 
## Changes
- Remove export_to_pretty_string
- Remove OperatorExportTypes and ExportTypes and all usages
- Remove _exporter_states


[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Sep 24, 2024
@justinchuby
[ONNX] Remove deprecated OperatorExportTypes and ExportTypes
23c552e 
ghstack-source-id: 6c1d495
Pull Request resolved: #136277

Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Update
6403d4d 
[ghstack-poisoned]
@justinchuby
Update
5997970 
[ghstack-poisoned]
@justinchuby justinchuby requested a review from albanD as a code owner September 24, 2024 23:19
@justinchuby
Update
65563d8 
[ghstack-poisoned]
@justinchuby justinchuby mentioned this pull request Sep 25, 2024
Closed
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 25, 2024
@justinchuby
[ONNX] Remove deprecated OperatorExportTypes and ExportTypes
f698de9 
ghstack-source-id: 51809fa
Pull Request resolved: pytorch#136277

Signed-off-by: Justin Chu <[email protected]>
malfet
malfet reviewed Sep 26, 2024
View reviewed changes
test/allowlist_for_publicAPI.json
],
"torch.onnx": [
"Dict",
"OperatorExportTypes",
Copy link
Contributor

@malfet malfet Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please elaborate where it was documented as deprecated?

malfet
malfet approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if we have a public document somewhere saying that onnx. OperatorExportTypes is deprecated

@kit1980
Copy link
Contributor

kit1980 commented Sep 26, 2024

I see OperatorExportTypes is used by some Meta projects.
Let's mark it clearly deprecated (with a decorator or a doc) for at least 1 release, I'll add it to TorchFix and try to clean up usages, and then we can remove the API completely.

@justinchuby
Copy link
Collaborator Author

justinchuby commented Sep 27, 2024 •
edited
Loading

Thanks, will mark as deprecated in documentation for now.

@justinchuby
Update
e39a0b7 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Sep 27, 2024
@justinchuby
[ONNX] Remove deprecated OperatorExportTypes and ExportTypes
dacf148 
ghstack-source-id: 65d9d79
Pull Request resolved: #136277

Signed-off-by: Justin Chu <[email protected]>
@albanD albanD removed their request for review October 4, 2024 19:00
@justinchuby justinchuby marked this pull request as draft October 11, 2024 16:27
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Dec 10, 2024
@github-actions github-actions bot closed this Jan 9, 2025
@justinchuby justinchuby reopened this Jan 9, 2025
@justinchuby justinchuby added no-stale and removed Stale labels Jan 9, 2025
@justinchuby justinchuby closed this Feb 6, 2025
@github-actions github-actions bot deleted the gh/justinchuby/101/head branch March 9, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@titaiwangms titaiwangms Awaiting requested review from titaiwangms

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

@kit1980 kit1980 Awaiting requested review from kit1980

+1 more reviewer

@xadupre xadupre xadupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: onnx Related to torch.onnx no-stale open source release notes: onnx torch.onnx related changes that should show up in the release notes suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@justinchuby @kit1980 @malfet @xadupre @pytorchbot