Skip to content

Don't run reshape pattern match on dynamic shape size tensor #136100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang wants to merge 2 commits into from
Closed

Don't run reshape pattern match on dynamic shape size tensor #136100

ezyang wants to merge 2 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 14, 2024 •
edited by pytorch-bot bot
Loading

@ezyang
Update
6364ac2 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136100

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 6eb2db5 with merge base failed to retrieve merge base, please contact dev infra:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Sep 14, 2024
@ezyang
Don't run reshape pattern match on dynamic shape size tensor
f6e1feb 
Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: e428eb5
Pull Request resolved: #136100
@ezyang ezyang requested a review from mengluy0125 September 14, 2024 19:10
@ezyang
Copy link
Contributor Author

ezyang commented Sep 14, 2024

@mengluy0125 as original author of this code could you take an action item for writing a test for this? https://fb.workplace.com/groups/1075192433118967/permalink/1501925720445634/

mengluy0125
mengluy0125 approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@mengluy0125 mengluy0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@mengluy0125
Copy link
Contributor

mengluy0125 commented Sep 16, 2024

@mengluy0125 as original author of this code could you take an action item for writing a test for this? https://fb.workplace.com/groups/1075192433118967/permalink/1501925720445634/

Sure.

@ezyang
Update
6eb2db5 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Sep 17, 2024
@ezyang
Don't run reshape pattern match on dynamic shape size tensor
d142fa7 
Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: 5caccd3
Pull Request resolved: #136100
@ezyang
Copy link
Contributor Author

ezyang commented Sep 17, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 17, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#136192

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Sep 17, 2024

@pytorchbot merge -f "unrelated problems"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mengluy0125
Copy link
Contributor

mengluy0125 commented Sep 17, 2024

Thanks @ezyang for the quick fix on the reshape node normalization on dynamic shapes to unblock MC experiments!

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@ezyang @Chao1Han
Don't run reshape pattern match on dynamic shape size tensor (pytorch…
df1bf35 
…#136100)

Signed-off-by: Edward Z. Yang <[email protected]>

Pull Request resolved: pytorch#136100
Approved by: https://github.com/mengluy0125
@github-actions github-actions bot deleted the gh/ezyang/2932/head branch October 19, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mengluy0125 mengluy0125 mengluy0125 approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: inductor topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @mengluy0125 @pytorchmergebot