Skip to content

Conversation

@yiming0416
Copy link
Contributor

@yiming0416 yiming0416 commented Sep 13, 2024

Improves and enables a commented out test originally introduced in #131912

In test_custom_tag_metadata_re_export(), we check the added "custom" metadata to given nodes is preserved and not copied to other nodes after re-exporting

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 13, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136048

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 17adc5f with merge base 3406ac2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yiming0416 yiming0416 force-pushed the yiming0416/enable_custom_re_export_test branch from b507694 to a4b725b Compare September 13, 2024 20:52
@yiming0416 yiming0416 marked this pull request as ready for review September 13, 2024 23:29
@yiming0416 yiming0416 force-pushed the yiming0416/enable_custom_re_export_test branch 2 times, most recently from d53da39 to fd0b1e0 Compare September 17, 2024 16:36
@facebook-github-bot
Copy link
Contributor

@yiming0416 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@yiming0416 yiming0416 force-pushed the yiming0416/enable_custom_re_export_test branch from fd0b1e0 to 5e460dd Compare September 17, 2024 17:59
@facebook-github-bot
Copy link
Contributor

@yiming0416 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@yiming0416 yiming0416 force-pushed the yiming0416/enable_custom_re_export_test branch from 5e460dd to 7550a6c Compare September 19, 2024 03:37
@facebook-github-bot
Copy link
Contributor

@yiming0416 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary:
Improves and enables a commented out test originally introduced in #131912

In `test_custom_tag_metadata_re_export()`, we check the added "custom" metadata to given nodes is preserved and not copied to other nodes after re-exporting


Reviewed By: zhxchen17

Differential Revision: D62880574

Pulled By: yiming0416
@facebook-github-bot facebook-github-bot force-pushed the yiming0416/enable_custom_re_export_test branch from 7550a6c to 17adc5f Compare September 23, 2024 00:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62880574

@yiming0416
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 23, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@yiming0416
Copy link
Contributor Author

@pytorchbot merge -f "landed internally"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
Improves and enables a commented out test originally introduced in pytorch#131912

In `test_custom_tag_metadata_re_export()`, we check the added "custom" metadata to given nodes is preserved and not copied to other nodes after re-exporting
Pull Request resolved: pytorch#136048
Approved by: https://github.com/zhxchen17
@github-actions github-actions bot deleted the yiming0416/enable_custom_re_export_test branch October 25, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants