Skip to content

Add Half support for reflection and replication padding on CPU #135931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CaoE wants to merge 1 commit into from
Closed

Add Half support for reflection and replication padding on CPU #135931

CaoE wants to merge 1 commit into from

Conversation

@CaoE
Copy link
Collaborator

@CaoE CaoE commented Sep 13, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135931

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1394be with merge base 3bebc09 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Sep 13, 2024
@CaoE CaoE added module: half Related to float16 half-precision floats release notes: nn release notes category ciflow/trunk Trigger trunk jobs on your pull request labels Sep 13, 2024
@CaoE CaoE changed the title Add Half support for reflection and replication padding Add Half support for reflection and replication padding on CPU Sep 13, 2024
Skylion007
Skylion007 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to tackle these ops myself.

Skylion007
Skylion007 reviewed Sep 13, 2024
View reviewed changes
torch/testing/_internal/common_methods_invocations.py
supports_fwgrad_bwgrad=True,
dtypes=all_types_and_complex_and(torch.bfloat16),
dtypesIfCUDA=all_types_and_complex_and(torch.half, torch.bfloat16),
dtypes=all_types_and_complex_and(torch.bfloat16, torch.half),
Copy link
Collaborator

@Skylion007 Skylion007 Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add to nn.functional.pad as well for replicate_negative

Copy link
Collaborator Author

@CaoE CaoE Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments. Add it.

@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Sep 14, 2024
@CaoE CaoE marked this pull request as ready for review September 14, 2024 05:05
@CaoE
Copy link
Collaborator Author

CaoE commented Sep 14, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 14, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 14, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@Skylion007
Copy link
Collaborator

Skylion007 commented Sep 14, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 14, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@CaoE @Chao1Han
Add Half support for reflection and replication padding on CPU (pytor…
28fe3fa 
…ch#135931)

Fixes pytorch#135680

Pull Request resolved: pytorch#135931
Approved by: https://github.com/Skylion007
@mikaylagawarecki mikaylagawarecki mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: half Related to float16 half-precision floats open source release notes: nn release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Meet an unimplemented crash for type 'Half' while the Data is not of Half type

4 participants

@CaoE @pytorchmergebot @Skylion007 @pytorchbot