Skip to content

Conversation

@anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Sep 13, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135922

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 20f322c with merge base eaba287 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

anijain2305 added a commit that referenced this pull request Sep 13, 2024
@anijain2305 anijain2305 added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels Sep 13, 2024
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanboliang
Copy link
Contributor

I think this won't impact OSS users, but we should check with internal users if this would break their models. cc @jackiexu1992 @mengluy0125

@anijain2305
Copy link
Contributor Author

anijain2305 commented Sep 13, 2024

Menglyu mentioned that it does not. They set it to empty internally, and the do a search for the best combination.

@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@laithsakka
Copy link
Contributor

reduced instruction counts of the following:
{
"add_loop_inductor": -14.414483048948,
"update_hint_regression": -6.227513177813
}

@github-actions github-actions bot deleted the gh/anijain2305/521/head branch October 14, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants