-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[inductor] Remove the batch fusion passes from being a default #135922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135922
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 20f322c with merge base eaba287 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eellison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @yanboliang
|
I think this won't impact OSS users, but we should check with internal users if this would break their models. cc @jackiexu1992 @mengluy0125 |
|
Menglyu mentioned that it does not. They set it to empty internally, and the do a search for the best combination. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
reduced instruction counts of the following: |
…ch#135922) Ads team do a search internally to figure out which fusion passes to use. Pull Request resolved: pytorch#135922 Approved by: https://github.com/eellison, https://github.com/yanboliang ghstack dependencies: pytorch#135819
Stack from ghstack (oldest at bottom):
Ads team do a search internally to figure out which fusion passes to use.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang