[ROCm] skip test_fp8_cast_and_t on non-MI300 machines #135917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135917
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6776f34 with merge base aaabfc8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: inductor
module: rocm
Collaborator
|
@malfet Please stamp, this is just to skip a failing unit test for ROCm to get ROCm CI back to green. |
Contributor
|
@jithunnair-amd done, but would be nice to mark PR ready for review :) |
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#135917 Approved by: https://github.com/malfet
Collaborator
|
@pytorchbot cherry-pick --onto release/2.5 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Fixes #ISSUE_NUMBER Pull Request resolved: #135917 Approved by: https://github.com/malfet (cherry picked from commit 6cdc70b)
Collaborator
Cherry picking #135917The cherry pick PR is at #136557 and it is recommended to link a critical cherry pick PR with an issue. Details for Dev Infra teamRaised by workflow job |
This was referenced Sep 24, 2024
atalman
pushed a commit
that referenced
this pull request
Sep 25, 2024
* [ROCm] skip test_fp8_cast_and_t on non-MI300 machines (#135917) Fixes #ISSUE_NUMBER Pull Request resolved: #135917 Approved by: https://github.com/malfet (cherry picked from commit 6cdc70b) * Skip pointwise associative scan tests due to regression (changes based on PR #135995) * Cherry-pick fix from #135702 --------- Co-authored-by: Prachi Gupta <[email protected]> Co-authored-by: Jithun Nair <[email protected]>
dnikolaev-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 3, 2024
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#135917 Approved by: https://github.com/malfet (cherry picked from commit 6cdc70b) (cherry picked from commit 16ebb15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang