Skip to content

[Fix]: Update CPUINFO submodule to fix support for NON-SVE ARM Hardware #135857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikhil-arm wants to merge 1 commit into from
Closed

[Fix]: Update CPUINFO submodule to fix support for NON-SVE ARM Hardware #135857

nikhil-arm wants to merge 1 commit into from

Conversation

@nikhil-arm
Copy link
Collaborator

@nikhil-arm nikhil-arm commented Sep 12, 2024 •
edited by malfet
Loading

Regression PR : pytorch/cpuinfo#255

Change-Id: I56cec061072be11ec33ccb661114360b979fc7aa

cc @malfet @snadampal @milpuz01

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 12, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135857

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit d98b35a with merge base c977bb7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@nikhil-arm
Copy link
Collaborator Author

nikhil-arm commented Sep 12, 2024

@pytorchbot label "module: arm"

@pytorch-bot pytorch-bot bot added the module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 label Sep 12, 2024
@nikhil-arm
Copy link
Collaborator Author

nikhil-arm commented Sep 12, 2024

@pytorchbot label "ciflow/linux-aarch64"

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024

Can't add following labels to PR: ciflow/linux-aarch64. Please ping one of the reviewers for help.

@nikhil-arm
Copy link
Collaborator Author

nikhil-arm commented Sep 12, 2024

cc: @malfet @maajidkhann @digantdesai can we please add aarch64 ci label to it. I dont have permission to do it

@nikhil-arm
Copy link
Collaborator Author

nikhil-arm commented Sep 12, 2024

CPUINFO Fix PR: pytorch/cpuinfo#258

@nikhil-arm nikhil-arm mentioned this pull request Sep 12, 2024
Closed
@cfRod
Copy link
Collaborator

cfRod commented Sep 12, 2024

@pytorchbot label "ciflow/linux-aarch64"

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024

Can't add following labels to PR: ciflow/linux-aarch64. Please ping one of the reviewers for help.

@cfRod
Copy link
Collaborator

cfRod commented Sep 12, 2024

@pytorchbot label "ciflow/linux-aarch64"

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024

Can't add following labels to PR: ciflow/linux-aarch64. Please ping one of the reviewers for help.

@robert-hardwick
Copy link
Collaborator

robert-hardwick commented Sep 12, 2024

@pytorchbot label "ciflow/linux-aarch64"

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024

Can't add following labels to PR: ciflow/linux-aarch64. Please ping one of the reviewers for help.

@malfet malfet added ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/trunk Trigger trunk jobs on your pull request labels Sep 12, 2024
@nikhil-arm
Copy link
Collaborator Author

nikhil-arm commented Sep 13, 2024 •
edited
Loading

We still see the timeout issue on test cases.
@maajidkhann as I suspected before, this will not fix the timeout issue

@maajidkhann
Copy link
Contributor

maajidkhann commented Sep 16, 2024

We still see the timeout issue on test cases. @maajidkhann as I suspected before, this will not fix the timeout issue

I think this PR pytorch/cpuinfo#258 fixed the error we were getting in these pipelines.

Error:
https://github.com/pytorch/pytorch/actions/runs/10777650193/job/29891036346?pr=119571#step:20:6914

upp

we don't see this error anymore in these pipelines.

I am not sure of the reason why this timeout issue is coming now in these pipelines.

@malfet
Copy link
Contributor

malfet commented Sep 17, 2024

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@nikhil-arm @pytorchmergebot
[Fix]: Update CPUINFO submodule to fix support for NON-SVE ARM Hardware
d98b35a 
Regression PR : pytorch/cpuinfo#255

Signed-off-by: Nikhil Gupta <[email protected]>
Change-Id: I56cec061072be11ec33ccb661114360b979fc7aa
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Successfully rebased update_cpuinfo onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_cpuinfo && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Merge failed

Reason: 4 jobs have failed, first few of them are: linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 1, 4, linux.arm64.2xlarge), linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 2, 4, linux.arm64.2xlarge), linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 3, 4, linux.arm64.2xlarge), linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 4, 4, linux.arm64.2xlarge)

Details for Dev Infra team Raised by workflow job

@nikhil-arm nikhil-arm mentioned this pull request Sep 17, 2024
Closed
@malfet
Copy link
Contributor

malfet commented Sep 17, 2024

@pytorchbot merge -f "aarch64 jobs times out, but likelihood that this PR caused is very low"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@maajidkhann maajidkhann mentioned this pull request Sep 18, 2024
Closed
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@nikhil-arm @Chao1Han
[Fix]: Update CPUINFO submodule to fix support for NON-SVE ARM Hardwa…
e5f33a2 
…re (pytorch#135857)

Regression PR : pytorch/cpuinfo#255

Change-Id: I56cec061072be11ec33ccb661114360b979fc7aa

Pull Request resolved: pytorch#135857
Approved by: https://github.com/digantdesai, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/trunk Trigger trunk jobs on your pull request Merged module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nikhil-arm @cfRod @robert-hardwick @maajidkhann @malfet @pytorchmergebot @digantdesai @pytorchbot