[inductor] Remove unused check #135787
Closed
[inductor] Remove unused check #135787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135787
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1cd2804 with merge base 0216936 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 12, 2024
This was referenced Sep 12, 2024
oulgen
approved these changes
Sep 12, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 13, 2024
An O(n^2) to O(n) improvement by not comparing all pairs of deps. Before:  After:  Pull Request resolved: #135788 Approved by: https://github.com/oulgen ghstack dependencies: #135787
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 13, 2024
This skips some unneeded work in the subclass. Pull Request resolved: #135820 Approved by: https://github.com/oulgen ghstack dependencies: #135787, #135788
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Pull Request resolved: #135821 Approved by: https://github.com/oulgen ghstack dependencies: #135787, #135788, #135820
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
I think this is unreachable code because mode is always None on reads. Pull Request resolved: pytorch#135787 Approved by: https://github.com/oulgen
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
An O(n^2) to O(n) improvement by not comparing all pairs of deps. Before:  After:  Pull Request resolved: pytorch#135788 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135787
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
This skips some unneeded work in the subclass. Pull Request resolved: pytorch#135820 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135787, pytorch#135788
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#135821 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135787, pytorch#135788, pytorch#135820
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
~2x speedup on this function, though saves <0.5s overall Pull Request resolved: pytorch#135822 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135787, pytorch#135788, pytorch#135820, pytorch#135821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I think this is unreachable code because mode is always None on reads.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang