Skip to content

Conversation

@clumsy
Copy link

@clumsy clumsy commented Sep 11, 2024

The torch.cat attr name for tensors in the docs differs from the method signature, unlike other methods.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135698

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit e0e678d with merge base ee8c5cc (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Sep 11, 2024
@clumsy clumsy force-pushed the fix/torch_cat_doc_attr branch from b8e5a8c to a8e45a3 Compare September 11, 2024 14:53
@clumsy clumsy force-pushed the fix/torch_cat_doc_attr branch from a8e45a3 to e0e678d Compare September 11, 2024 14:58
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 11, 2024
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@albanD albanD added release notes: python_frontend python frontend release notes category topic: docs topic category and removed release notes: dataloader release notes category labels Sep 11, 2024
@albanD
Copy link
Collaborator

albanD commented Sep 11, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 11, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@clumsy clumsy deleted the fix/torch_cat_doc_attr branch September 12, 2024 00:41
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
The `torch.cat` attr name for tensors in the docs differs from the method signature, unlike other methods.
Pull Request resolved: pytorch#135698
Approved by: https://github.com/albanD

Co-authored-by: Alexander Jipa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants