Improve performance of sympy_generic_le #135622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135622
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit a44ab7c with merge base b7eb725 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
module: cpu
ezyang
approved these changes
Sep 11, 2024
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
need lintfix but lgtm. Maybe land this one separately
This was referenced Sep 11, 2024
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #135652 Approved by: https://github.com/ezyang ghstack dependencies: #135621, #135622
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#135622 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#135621
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#135652 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#135621, pytorch#135622
KnAwnime
pushed a commit
to KnAwnime/Biblioteka
that referenced
this pull request
Oct 16, 2024
ghstack-source-id: ca1da18 Pull Request resolved: pytorch/pytorch#135622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10