[Cherry-Pick] Bump triton pin and release version, revert temporary changes to build from pin, use pytorch-triton package #135613
Conversation
…for first RC (pytorch#135517)" This reverts commit 4a3dabd.
atalman
requested review from
Chillee,
bertmaher,
desertfire,
eellison,
jataylo,
jithunnair-amd,
pruthvistony and
shunting314
as code owners
pytorch-bot
bot
added
ciflow/inductor
ciflow/trunk
| @@ -1 +1 @@ | |||
| 757b6a61e7df814ba806f498f8bb3160f84b120c | |||
| 5fe38ffd73c2ac6ed6323b554205186696631c6f | |||
There was a problem hiding this comment.
Should this be a pin or a branch?
There was a problem hiding this comment.
Branch. To get green signal on PR, we need to bump the pin as well.
| # Only linux Python < 3.13 are supported wheels for triton | ||
| TRITON_REQUIREMENT="triton==${TRITON_VERSION}; ${TRITON_CONSTRAINT}" | ||
| if [[ -n "$PYTORCH_BUILD_VERSION" ]]; then | ||
| TRITON_REQUIREMENT="pytorch-triton==${TRITON_VERSION}; ${TRITON_CONSTRAINT}" |
There was a problem hiding this comment.
This feels like something we shouldn't be doing?
There was a problem hiding this comment.
This job builds pytorch-triton package. Here is the workflow from 2.4:
https://github.com/pytorch/pytorch/actions/runs/10200015317/job/28218504485#step:8:51 . For RC builds we use this package that we build. Once we are happy with it, release to pypi happens. Then we use triton package.
There was a problem hiding this comment.
Should we undo those changes on trunk than?
There was a problem hiding this comment.
Yes, agree. Will post a change with this to trunk. It will save us 1 cherry-pick during the release process.
| env: | ||
| IS_RELEASE_TAG: ${{ startsWith(github.event.ref, 'refs/tags/v') }} |
There was a problem hiding this comment.
It feels like this is something that should have been landed in main first, and than cherry-picked into release
There was a problem hiding this comment.
Its part of the revert, we actually first RC from pin rather then branch since branch was not ready 4a3dabd.
This code is already a part of main
atalman
changed the title
Similar with pytorch#135627 Pull Request resolved: pytorch#135638 Approved by: https://github.com/atalman
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
Sure, though again, it feels we are doing a bit more changes that what is mentioned in cherry-pick/revert
atalman
changed the title
3 participants
Cherry-Pick Bump triton pin and release version #135627
Cherry Pick Bump triton xpu pin and release version #135638
Use
pytorch-tritonpackage instead of triton untilltritonis released to pypi. Workflow for triton package is that: We use pytorch-triton package untill we are are ready to release to pypi. Once pypi is released we use triton package. Disadvantage here, is this temp change required. Advantage is that we know that pytorch-triton package build by our CD. triton package build by OpenAI.Revert Temp Release only changes to build from pin: [RELEASE-ONLY CHANGES] Temp changes to build triton from pin for first RC #135517
So far we followed this process:
I think for future releases we should do something like this: