Skip to content

Make sure all SDPA tests are ran with tensor cores enabled #135592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drisspg wants to merge 3 commits into from
Closed

Make sure all SDPA tests are ran with tensor cores enabled #135592

drisspg wants to merge 3 commits into from

Conversation

@drisspg
Copy link
Contributor

@drisspg drisspg commented Sep 10, 2024 •
edited
Loading

@drisspg
Update
0f0c779 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135592

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 11a53a4 with merge base 4dd04db (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

drisspg added a commit that referenced this pull request Sep 10, 2024
@drisspg
Make sure all SDPA tests are ran with tensor cores enabled
5b55142 
ghstack-source-id: d9cb2e3
Pull Request resolved: #135592
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 10, 2024
Skylion007
Skylion007 reviewed Sep 11, 2024
View reviewed changes
@drisspg drisspg mentioned this pull request Oct 11, 2024
Closed
eqy
eqy reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@eqy eqy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same functionality as @tf32_on or @tf32_on_and_off(tf32_tol) ?

@drisspg
Update
f372202 
[ghstack-poisoned]
drisspg added a commit that referenced this pull request Oct 17, 2024
@drisspg
Make sure all SDPA tests are ran with tensor cores enabled
e1b472e 
ghstack-source-id: a79fd7c
Pull Request resolved: #135592
@drisspg
Update
11a53a4 
[ghstack-poisoned]
drisspg added a commit that referenced this pull request Oct 29, 2024
@drisspg
Make sure all SDPA tests are ran with tensor cores enabled
3b79dae 
ghstack-source-id: 40c5b07
Pull Request resolved: #135592
@drisspg
Copy link
Contributor Author

drisspg commented Oct 29, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 29, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 29, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@drisspg @rahulsingh-intel
Make sure all SDPA tests are ran with tensor cores enabled (pytorch#1…
079bcd0 
…35592)

Pull Request resolved: pytorch#135592
Approved by: https://github.com/eqy
@github-actions github-actions bot deleted the gh/drisspg/48/head branch November 29, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@eqy eqy eqy approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@drisspg @pytorchmergebot @Skylion007 @eqy