Revert "[fx] Bypass custom __setattr__ in Node.__init__ (#135079)" #135562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 66da3b3.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135562
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e9e4212 with merge base 7ec17b4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jansel
approved these changes
Sep 10, 2024
seemethere
approved these changes
Sep 10, 2024
Contributor
Author
|
@pytorchbot merge -f 'revert, PR signals passed' |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Sep 10, 2024
Contributor
|
the revert has the following negative effect on perf numbers |
jansel
added a commit
to jansel/pytorch
that referenced
this pull request
Sep 11, 2024
Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally.
This was referenced Sep 11, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Relands #135079 whcih was reverted by #135562 I broke this up into three parts to test internally. Pull Request resolved: #135733 Approved by: https://github.com/oulgen
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Relands #135079 whcih was reverted by #135562 I broke this up into three parts to test internally. Pull Request resolved: #135735 Approved by: https://github.com/oulgen
jansel
added a commit
to jansel/pytorch
that referenced
this pull request
Sep 12, 2024
Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally.
atalman
pushed a commit
that referenced
this pull request
Sep 19, 2024
#135625) Revert "[fx] Bypass custom __setattr__ in Node.__init__ (#135079)" (#135562) This reverts commit 66da3b3. #135079 breaks internal tests and needs to be reverted. Revert with mergebot doesn't work as this PR is technically part of the stack, but, according to @jansel, it should be possible to revert it individually. Pull Request resolved: #135562 Approved by: https://github.com/jansel, https://github.com/seemethere Co-authored-by: Ivan Zaitsev <[email protected]>
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…)" (pytorch#135562) This reverts commit 66da3b3. pytorch#135079 breaks internal tests and needs to be reverted. Revert with mergebot doesn't work as this PR is technically part of the stack, but, according to @jansel, it should be possible to revert it individually. Pull Request resolved: pytorch#135562 Approved by: https://github.com/jansel, https://github.com/seemethere
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…135733) Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally. Pull Request resolved: pytorch#135733 Approved by: https://github.com/oulgen
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…135735) Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally. Pull Request resolved: pytorch#135735 Approved by: https://github.com/oulgen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 66da3b3.
#135079 breaks internal tests and needs to be reverted. Revert with mergebot doesn't work as this PR is technically part of the stack, but, according to @jansel, it should be possible to revert it individually.