[ONNX] Update fake mode usage in onnx docs #135512

shubhambhokare1 · 2024-09-09T18:03:38Z

Update fake mode usage in onnx docs

pytorch-bot · 2024-09-09T18:03:41Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135512

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Unrelated Failures

As of commit 90f6f27 with merge base cbc6b30 ():

NEW FAILURE - The following job has failed:

pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 5, 5, lf.linux.4xlarge.nvidia.gpu) (gh)
'test/profiler/test_cpp_thread.py::CppThreadTest::test_profile_memory'

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-docs / build-docs-python-false (gh) (trunk failure)
pull / linux-focal-py3.11-clang10 / test (dynamo, 2, 3, lf.linux.2xlarge) (gh) (trunk failure)
test_nestedtensor.py::TestNestedTensorSubclassCPU::test_to_padded_tensor_nt_dim_2_requires_grad_False_cpu_float16
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge) (gh) (trunk failure)
test_nestedtensor.py::TestNestedTensorSubclassCPU::test_to_padded_tensor_nt_dim_2_requires_grad_False_cpu_float16
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 3, 3, linux.2xlarge) (gh) (trunk failure)
test_nestedtensor.py::TestNestedTensorSubclassCPU::test_to_padded_tensor_nt_dim_2_requires_grad_False_cpu_float16
pull / linux-focal-py3.9-clang10 / test (dynamo, 3, 3, lf.linux.2xlarge) (gh) (trunk failure)
test_nestedtensor.py::TestNestedTensorSubclassCPU::test_to_padded_tensor_nt_dim_2_requires_grad_False_cpu_float16

This comment was automatically generated by Dr. CI and updates every 15 minutes.

justinchuby

Thanks!

shubhambhokare1 · 2024-09-09T18:09:02Z

@pytorchbot merge -f "all relevant tests passed"

pytorchmergebot · 2024-09-09T18:10:31Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

justinchuby · 2024-09-09T19:30:20Z

The release was cut: https://github.com/pytorch/pytorch/commits/release/2.5/ This may need cherry-picking @shubhambhokare1

davidberard98 · 2024-09-09T20:13:31Z

@pytorchbot revert -c ignoredsignal -m "failing test https://github.com/pytorch/pytorch/actions/runs/10778813316/job/29891679127"

pytorchmergebot · 2024-09-09T20:15:09Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit a13c118. Reverted #135512 on behalf of https://github.com/davidberard98 due to failing test https://github.com/pytorch/pytorch/actions/runs/10778813316/job/29891679127 ([comment](#135512 (comment)))

pytorchmergebot · 2024-09-09T20:15:15Z

@shubhambhokare1 your PR has been successfully reverted.

torch/onnx/_internal/_exporter_legacy.py

Co-authored-by: Justin Chu <[email protected]>

shubhambhokare1 · 2024-09-11T21:27:20Z

@pytorchbot merge -f "all relevant tests passed"

pytorchmergebot · 2024-09-11T21:28:51Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Update fake mode usage in onnx docs Pull Request resolved: pytorch#135512 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <[email protected]> (cherry picked from commit 66db61f)

Update fake mode usage in onnx docs Pull Request resolved: pytorch#135512 Approved by: https://github.com/justinchuby

This reverts commit a13c118. Reverted pytorch#135512 on behalf of https://github.com/davidberard98 due to failing test https://github.com/pytorch/pytorch/actions/runs/10778813316/job/29891679127 ([comment](pytorch#135512 (comment)))

Update fake mode usage in onnx docs Pull Request resolved: pytorch#135512 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <[email protected]>

…d Drop final None values as inputs for nodes in exporter graph (#135520) (#136005) * [ONNX] Update fake mode usage in onnx docs (#135512) Update fake mode usage in onnx docs Pull Request resolved: #135512 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <[email protected]> (cherry picked from commit 66db61f) * [ONNX] Drop final None values as inputs for nodes in exporter graph (#135520) When value for an optional input is not provided, it is defaulted to `None`, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are all `None`, strip them in the graph. Pull Request resolved: #135520 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <[email protected]> (cherry picked from commit e2f9a83)

shubhambhokare1 requested review from justinchuby, titaiwangms and wschin as code owners September 9, 2024 18:03

pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 9, 2024

shubhambhokare1 changed the title ~~Update fake mode usage in onnx docs~~ [ONNX] Update fake mode usage in onnx docs Sep 9, 2024

justinchuby approved these changes Sep 9, 2024

View reviewed changes

pytorchmergebot added the merging label Sep 9, 2024

pytorchmergebot closed this in a13c118 Sep 9, 2024

pytorchmergebot added Merged and removed merging labels Sep 9, 2024

pytorchbot added the open source label Sep 9, 2024

justinchuby added this to the 2.5.0 milestone Sep 9, 2024

pytorchmergebot added the Reverted label Sep 9, 2024

pytorchmergebot reopened this Sep 9, 2024

justinchuby reviewed Sep 9, 2024

View reviewed changes

torch/onnx/_internal/_exporter_legacy.py Outdated Show resolved Hide resolved

modify example

c6d6e7b

shubhambhokare1 force-pushed the sbhokare/update-docs-faketens branch from a412537 to c6d6e7b Compare September 9, 2024 20:58

justinchuby reviewed Sep 10, 2024

View reviewed changes

torch/onnx/_internal/_exporter_legacy.py Outdated Show resolved Hide resolved

justinchuby approved these changes Sep 10, 2024

View reviewed changes

titaiwangms added topic: docs topic category module: onnx Related to torch.onnx labels Sep 10, 2024

Update torch/onnx/_internal/_exporter_legacy.py

90f6f27

Co-authored-by: Justin Chu <[email protected]>

pytorchmergebot added the merging label Sep 11, 2024

pytorchmergebot closed this in 66db61f Sep 11, 2024

pytorchmergebot removed the merging label Sep 11, 2024

This was referenced Sep 13, 2024

[Cherry-pick] [ONNX] Update fake mode usage in onnx docs (#135512) and Drop final None values as inputs for nodes in exporter graph (#135520) #136005

Merged

[v.2.5.0] Release Tracker #135522

Closed

atalman mentioned this pull request Oct 8, 2024

Release 2.5.0 validations checklist and cherry-picks #137492

Closed

56 tasks

github-actions bot deleted the sbhokare/update-docs-faketens branch October 13, 2024 02:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ONNX] Update fake mode usage in onnx docs #135512

[ONNX] Update fake mode usage in onnx docs #135512

Uh oh!

shubhambhokare1 commented Sep 9, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Sep 9, 2024 •

edited

Loading

Uh oh!

justinchuby left a comment

Uh oh!

shubhambhokare1 commented Sep 9, 2024

Uh oh!

pytorchmergebot commented Sep 9, 2024

Uh oh!

justinchuby commented Sep 9, 2024

Uh oh!

davidberard98 commented Sep 9, 2024

Uh oh!

pytorchmergebot commented Sep 9, 2024

Uh oh!

pytorchmergebot commented Sep 9, 2024

Uh oh!

Uh oh!

Uh oh!

shubhambhokare1 commented Sep 11, 2024

Uh oh!

pytorchmergebot commented Sep 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[ONNX] Update fake mode usage in onnx docs #135512

[ONNX] Update fake mode usage in onnx docs #135512

Uh oh!

Conversation

shubhambhokare1 commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135512

❌ 1 New Failure, 5 Unrelated Failures

Uh oh!

justinchuby left a comment

Choose a reason for hiding this comment

Uh oh!

shubhambhokare1 commented Sep 9, 2024

Uh oh!

pytorchmergebot commented Sep 9, 2024

Merge started

Uh oh!

justinchuby commented Sep 9, 2024

Uh oh!

davidberard98 commented Sep 9, 2024

Uh oh!

pytorchmergebot commented Sep 9, 2024

Uh oh!

pytorchmergebot commented Sep 9, 2024

Uh oh!

Uh oh!

Uh oh!

shubhambhokare1 commented Sep 11, 2024

Uh oh!

pytorchmergebot commented Sep 11, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shubhambhokare1 commented Sep 9, 2024 •

edited

Loading

pytorch-bot bot commented Sep 9, 2024 •

edited

Loading