Skip to content

[split build] move periodic split builds into own concurrency group #135510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PaliC wants to merge 3 commits into from
Closed

[split build] move periodic split builds into own concurrency group #135510

PaliC wants to merge 3 commits into from

Conversation

@PaliC
Copy link
Contributor

@PaliC PaliC commented Sep 9, 2024 •
edited by malfet
Loading

To avoid nightly workflows cancelling each other

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135510

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 0d78c03 with merge base 73a6fc6 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 9, 2024
@PaliC PaliC marked this pull request as ready for review September 9, 2024 17:55
@PaliC PaliC requested a review from a team as a code owner September 9, 2024 17:55
@PaliC
Copy link
Contributor Author

PaliC commented Sep 9, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 9, 2024
huydhn
huydhn approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So, just to confirm we want to run split build with ciflow/periodic on PR but on all trunk commits (push to main, not periodic)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 9, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 9, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

malfet
malfet reviewed Sep 9, 2024
View reviewed changes
@malfet
Copy link
Contributor

malfet commented Sep 9, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 9, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Sep 9, 2024

@pytorchbot merge -f "Lint and specific -split- workflows are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 9, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 9, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet mentioned this pull request Sep 13, 2024
Closed
malfet added a commit that referenced this pull request Sep 13, 2024
@malfet
Fix bug in split-build workflows codegen
1c01fc4 
By just deleting a few rogue lines left out in #135510
If file in workflows folder does not have a `.yml` extensions it will not be launched at all, will it?
pytorchmergebot pushed a commit that referenced this pull request Sep 13, 2024
@malfet @pytorchmergebot
Fix bug in split-build workflows codegen (#136043)
a30d5ba 
By just deleting a few rogue lines left out in #135510
If file in workflows folder does not have a `.yml` extensions it will not be launched at all, will it?

Pull Request resolved: #136043
Approved by: https://github.com/kit1980, https://github.com/atalman
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@PaliC @malfet @Chao1Han
[split build] move periodic split builds into own concurrency group (p…
9feb9dc 
…ytorch#135510)

To avoid nightly workflows cancelling each other
Pull Request resolved: pytorch#135510
Approved by: https://github.com/clee2000, https://github.com/huydhn, https://github.com/malfet

Co-authored-by: Nikita Shulga <[email protected]>
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@malfet @Chao1Han
Fix bug in split-build workflows codegen (pytorch#136043)
fd28c98 
By just deleting a few rogue lines left out in pytorch#135510
If file in workflows folder does not have a `.yml` extensions it will not be launched at all, will it?

Pull Request resolved: pytorch#136043
Approved by: https://github.com/kit1980, https://github.com/atalman
atalman pushed a commit to atalman/pytorch that referenced this pull request Oct 3, 2024
@PaliC @malfet @atalman
[split build] move periodic split builds into own concurrency group (p…
e4624c6 
…ytorch#135510)

To avoid nightly workflows cancelling each other
Pull Request resolved: pytorch#135510
Approved by: https://github.com/clee2000, https://github.com/huydhn, https://github.com/malfet

Co-authored-by: Nikita Shulga <[email protected]>
This was referenced Oct 3, 2024
Merged
Closed
kit1980 pushed a commit that referenced this pull request Oct 3, 2024
@atalman @PaliC @malfet
[split build] move periodic split builds into own concurrency group (#…
417a076 
…135510) (#137265)

To avoid nightly workflows cancelling each other
Pull Request resolved: #135510
Approved by: https://github.com/clee2000, https://github.com/huydhn, https://github.com/malfet

Co-authored-by: Sahan Paliskara <[email protected]>
Co-authored-by: Nikita Shulga <[email protected]>
@github-actions github-actions bot deleted the palic/split2 branch October 12, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@huydhn huydhn huydhn approved these changes

@clee2000 clee2000 clee2000 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PaliC @pytorchmergebot @malfet @huydhn @clee2000