[aotd] debug profile runtime durations #135501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135501
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit d96cb82 with merge base dfb2b66 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
reviewed
Sep 10, 2024
|
|
||
| # Key to use for AOTAutogradCache | ||
| cache_key: Optional[str] = None | ||
| profile_duration: bool = os.environ.get("PYTORCH_AOTD_DEBUG_PROFILE", "0") == "1" |
Contributor
There was a problem hiding this comment.
Wouldn't it be better for this to be controlled in torch/_functorch/config.py? Rather than randomly scattered here
Contributor
Author
There was a problem hiding this comment.
Oh, yes, did not know about functorch/config.
ezyang
reviewed
Sep 10, 2024
|
|
||
| def get_events() -> List[Event]: | ||
| global events | ||
| return events |
Contributor
Contributor
Author
There was a problem hiding this comment.
Thanks. Mostly did it for debug profiling, we can ignore this PR. I will start using James's profiler when start working on subclasses compilation perf.
Contributor
Author
|
Abandoning in favor of #136478 |
injiiiiil
pushed a commit
to injiiiiil/654
that referenced
this pull request
Oct 1, 2024
ghstack-source-id: 63e440b Pull Request resolved: pytorch/pytorch#135501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):