Skip to content

Conversation

@hvaara
Copy link
Contributor

@hvaara hvaara commented Sep 8, 2024

Updating the comments with references to better places for context now that the bugs have been identified.

xref #135442 #135447 #134184

cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135448

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2a67473 with merge base 042f2f7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 8, 2024
@hvaara
Copy link
Contributor Author

hvaara commented Sep 8, 2024

@pytorchbot label "module: mps"

@pytorch-bot pytorch-bot bot added the module: mps Related to Apple Metal Performance Shaders framework label Sep 8, 2024
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pytorchbot merge

@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 9, 2024
@hvaara
Copy link
Contributor Author

hvaara commented Sep 9, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 9, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@hvaara hvaara deleted the update-replication-pad-decorators branch September 9, 2024 17:13
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Updating the comments with references to better places for context now that the bugs have been identified.

xref pytorch#135442 pytorch#135447 pytorch#134184

Pull Request resolved: pytorch#135448
Approved by: https://github.com/ezyang
apakbin pushed a commit to apakbin/pytorch that referenced this pull request Feb 14, 2025
Updating the comments with references to better places for context now that the bugs have been identified.

xref pytorch#135442 pytorch#135447 pytorch#134184

Pull Request resolved: pytorch#135448
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: mps Related to Apple Metal Performance Shaders framework open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants