[inductor] Cache get_operation_names/get_buffer_names #135446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135446
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a0bfb45 with merge base 8c738c9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
oulgen
reviewed
Sep 9, 2024
| @cache_on_self | ||
| def get_buffer_names(self) -> OrderedSet[str]: | ||
| return OrderedSet(out.get_name() for out in self.outputs) | ||
| return OrderedSet([out.get_name() for out in self.outputs]) |
Contributor
There was a problem hiding this comment.
Is this optimization actually safe? can't self.outputs change?
Contributor
Author
There was a problem hiding this comment.
No, they are immutable.
oulgen
approved these changes
Sep 12, 2024
This was referenced Sep 12, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Pull Request resolved: #135776 Approved by: https://github.com/oulgen ghstack dependencies: #135445, #135446
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Before:  After:  Pull Request resolved: pytorch#135446 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135445
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#135776 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135445, pytorch#135446
KnAwnime
pushed a commit
to KnAwnime/Biblioteka
that referenced
this pull request
Oct 16, 2024
ghstack-source-id: 5506449 Pull Request resolved: pytorch/pytorch#135446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Before:
After:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang