Skip to content

[MPS] Add regression test for fft.fftfreq #135440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hvaara wants to merge 2 commits into from
Closed

[MPS] Add regression test for fft.fftfreq #135440

hvaara wants to merge 2 commits into from

Conversation

@hvaara
Copy link
Contributor

@hvaara hvaara commented Sep 8, 2024

The issue reported in #135223 was already solved in #128393. This PR adds a regression test for it.

Fixes #135223

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135440

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit fb61629 with merge base 042f2f7 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 8, 2024
ezyang
ezyang approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pytorchbot merge

@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 9, 2024
@hvaara
Copy link
Contributor Author

hvaara commented Sep 9, 2024

@pytorchbot label ciflow/mps

@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Sep 9, 2024
@hvaara
Copy link
Contributor Author

hvaara commented Sep 9, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 9, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 9, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@hvaara
Copy link
Contributor Author

hvaara commented Sep 9, 2024

TIL the macOS test are part of trunk via trunk / macos-py3-arm64. So there's no need to manually add the ciflow/mps label right before a merge attempt.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 9, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 5, 5, linux.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor

ezyang commented Sep 9, 2024

@pytorchbot merge -f "flaky test"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 9, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@hvaara hvaara deleted the regression-test-for-135223 branch September 9, 2024 17:13
@hvaara hvaara mentioned this pull request Sep 9, 2024
Closed
yushangdi pushed a commit that referenced this pull request Sep 12, 2024
@hvaara @yushangdi
[MPS] Add regression test for fft.fftfreq (#135440)
9d3b0f5 
The issue reported in #135223 was already solved in #128393. This PR adds a regression test for it.

Fixes #135223

Pull Request resolved: #135440
Approved by: https://github.com/ezyang
tolleybot pushed a commit to tolleybot/pytorch that referenced this pull request Sep 14, 2024
@hvaara @tolleybot
[MPS] Add regression test for fft.fftfreq (pytorch#135440)
0cd52ed 
The issue reported in pytorch#135223 was already solved in pytorch#128393. This PR adds a regression test for it.

Fixes pytorch#135223

Pull Request resolved: pytorch#135440
Approved by: https://github.com/ezyang
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@hvaara @Chao1Han
[MPS] Add regression test for fft.fftfreq (pytorch#135440)
f3fec52 
The issue reported in pytorch#135223 was already solved in pytorch#128393. This PR adds a regression test for it.

Fixes pytorch#135223

Pull Request resolved: pytorch#135440
Approved by: https://github.com/ezyang
@kit1980
Copy link
Contributor

kit1980 commented Oct 2, 2024

@pytorchbot cherry-pick -c critical --onto release/2.5

pytorchbot pushed a commit that referenced this pull request Oct 2, 2024
@hvaara @pytorchbot
[MPS] Add regression test for fft.fftfreq (#135440)
894c46b 
The issue reported in #135223 was already solved in #128393. This PR adds a regression test for it.

Fixes #135223

Pull Request resolved: #135440
Approved by: https://github.com/ezyang

(cherry picked from commit 09287e3)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Oct 2, 2024

Cherry picking #135440

The cherry pick PR is at #137215 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 2, 2024
Closed
kit1980 pushed a commit that referenced this pull request Oct 2, 2024
@pytorchbot @hvaara
[MPS] Add regression test for fft.fftfreq (#137215)
783a6a4 
[MPS] Add regression test for `fft.fftfreq` (#135440)

The issue reported in #135223 was already solved in #128393. This PR adds a regression test for it.

Fixes #135223

Pull Request resolved: #135440
Approved by: https://github.com/ezyang

(cherry picked from commit 09287e3)

Co-authored-by: Roy Hvaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.fft.fftfreq behaves unexpectedly when run on MPS backend

5 participants

@hvaara @pytorchmergebot @ezyang @kit1980 @pytorchbot