[inductor][cpp][gemm] reduce memory alloc overhead by allocating local acc once per thread #135277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135277
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 2e8aa41 with merge base 32f3af7 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
leslie-fang-intel
approved these changes
Sep 7, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 7, 2024
Pull Request resolved: #133447 Approved by: https://github.com/leslie-fang-intel ghstack dependencies: #135277 Co-authored-by: Wu, Chunyuan <[email protected]>
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 7, 2024
Pull Request resolved: #133538 Approved by: https://github.com/leslie-fang-intel ghstack dependencies: #135277, #133447 Co-authored-by: Wu, Chunyuan <[email protected]>
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…l acc once per thread (pytorch#135277) Pull Request resolved: pytorch#135277 Approved by: https://github.com/leslie-fang-intel Co-authored-by: Wu, Chunyuan <[email protected]>
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#133447 Approved by: https://github.com/leslie-fang-intel ghstack dependencies: pytorch#135277 Co-authored-by: Wu, Chunyuan <[email protected]>
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…ch#133538) Pull Request resolved: pytorch#133538 Approved by: https://github.com/leslie-fang-intel ghstack dependencies: pytorch#135277, pytorch#133447 Co-authored-by: Wu, Chunyuan <[email protected]>
KnAwnime
pushed a commit
to KnAwnime/Biblioteka
that referenced
this pull request
Oct 16, 2024
…l acc once per thread ghstack-source-id: 6bb3af3 Pull Request resolved: pytorch/pytorch#135277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang