Skip to content

Tests Generelization for multiple accelerator devices #135242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rahulsingh-intel wants to merge 50 commits into from
Closed

Tests Generelization for multiple accelerator devices #135242

rahulsingh-intel wants to merge 50 commits into from

Conversation

@rahulsingh-intel
Copy link
Contributor

@rahulsingh-intel rahulsingh-intel commented Sep 5, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135242

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4aec93c with merge base 228963a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pytorchmergebot (b026ea2, 8aadc1d, 5d9c152, 4aec93c)
  • ✅ login: cyyever / name: cyyever (563aef3, c5ac0db, ca902bc, 22a5640, 7623420, 2a555d2, c3571c0)
  • ✅ login: dependabot[bot] (29b5004, b5566b3)
  • ✅ login: guangyey / name: Yu, Guangye (7772ced)
  • ✅ login: amd-jmacaran / name: Joseph Macaranas (0c307b5)
  • ✅ login: mikaylagawarecki (6dcf780)
  • ✅ login: aakhundov / name: Adnan Akhundov (b47e60b)
  • ✅ login: majian4work / name: Ma Jian (3af2ca1)
  • ✅ login: rahulsingh-intel (ebfa33a)
  • ✅ login: r-barnes / name: Richard Barnes (45ea5dc)
  • ✅ login: avikchaudhuri / name: Avik Chaudhuri (01a3dfe)
  • ✅ login: williamwen42 / name: William Wen (32ddf67, d2688ec, b6d0cdb)
  • ✅ login: wz337 / name: Iris Z (b2c21bc)
  • ✅ login: desertfire / name: Bin Bao (922070a)
  • ✅ login: xmfan / name: Simon Fan (37ab8b9)
  • ✅ login: svekars / name: Svetlana Karslioglu (f9941eb)
  • ✅ login: jeffdaily / name: Jeff Daily (a7d4fae)
  • ✅ login: StrongerXi / name: Xiangxi Guo (Ryan) (2aa14e4)
  • ✅ login: malfet / name: Nikita Shulga (1010e6f, 53195f0)
  • ✅ login: chuanqi129 / name: Wang, Chuanqi (4df13c3)
  • ✅ login: tugsbayasgalan / name: Tugsbayasgalan Manlaibaatar (6224772)
  • ✅ login: jbschlosser / name: Joel Schlosser (e0bb8b0)
  • ✅ login: jansel / name: Jason Ansel (c821aaa)
  • ✅ login: guilhermeleobas / name: Guilherme Leobas (7c258d1, ae1c050)
  • ✅ login: dvorjackz / name: Jack Zhang (cd164c9)
  • ✅ login: syed-ahmed / name: Syed Tousif Ahmed (611a307)
  • ✅ login: eellison (c07a7dd)
  • ✅ login: anijain2305 / name: Animesh Jain (32ea866, b98d7d2, 4f1b6ac)
  • ✅ login: swolchok / name: Scott Wolchok (f2f4909)
  • ✅ login: yf225 / name: Will Feng (46bd11d)
  • ✅ login: eqy (cc59e91)
  • ✅ login: yiming0416 / name: Yiming Zhou (4980c06)
  • ✅ login: shink / name: Yuanhao Ji (d5bedbf)
  • ✅ login: kundaMwiza / name: Mwiza (0c46c11)

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Sep 5, 2024
zeshengzong
zeshengzong reviewed Sep 6, 2024
View reviewed changes
test/distributed/fsdp/test_fsdp_uneven.py Outdated
Copy link
Contributor

@zeshengzong zeshengzong Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, this might optimized to pythonic expression, like to_device = self.rank if TEST_CUDA else device I think. :D

And I saw there's some repeating in this logic, extract a method might be an option to reduce duplication, and convenient for other device if they want to reuse test-cases as well. Thanks

@soulitzer soulitzer requested a review from awgu September 6, 2024 01:25
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 6, 2024
@ankurneog ankurneog mentioned this pull request Sep 6, 2024
Closed
@rahulsingh-intel rahulsingh-intel changed the title Tets Generelization for multiple accelerator device Tests Generelization for multiple accelerator devices Sep 6, 2024
@jarias-lfx
Copy link

jarias-lfx commented Sep 10, 2024

/easycla

@ankurneog
Copy link

ankurneog commented Sep 27, 2024

@rahulsingh-intel : can you please address this change pointed out by @awgu to the PR after rebase to main. #133209 (comment). Thanks

@pytorch-bot pytorch-bot bot added module: compiled autograd compiled_autograd module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: inductor module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration NNC labels Oct 29, 2024
@rahulsingh-intel rahulsingh-intel mentioned this pull request Oct 29, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Dec 11, 2024
@rahulsingh-intel @guangyey @pytorchmergebot
Tests Generelization for multiple accelerator devices (#139184)
b576a8c 
Motivation: Generalize unit tests so that can be executed for cuda and non cuda devices.
Depedency : #133209  Merged now.
There was a #135242  for these changes and closed due to in correct commits. I have incoroprated the changes as suggested in comments.
@kwen2501  @zeshengzong Please review the changes.

Pull Request resolved: #139184
Approved by: https://github.com/kwen2501

Co-authored-by: Yu, Guangye <[email protected]>
pytorchmergebot pushed a commit that referenced this pull request Jan 7, 2025
@rahulsingh-intel @guangyey @pytorchmergebot
Tests Generelization for multiple accelerator devices (#139184)
bf7747e 
Motivation: Generalize unit tests so that can be executed for cuda and non cuda devices.
Depedency : #133209  Merged now.
There was a #135242  for these changes and closed due to in correct commits. I have incoroprated the changes as suggested in comments.
@kwen2501  @zeshengzong Please review the changes.

Pull Request resolved: #139184
Approved by: https://github.com/kwen2501

Co-authored-by: Yu, Guangye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awgu awgu Awaiting requested review from awgu

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

@bdhirsh bdhirsh Awaiting requested review from bdhirsh bdhirsh is a code owner

@zou3519 zou3519 Awaiting requested review from zou3519 zou3519 is a code owner

@Chillee Chillee Awaiting requested review from Chillee Chillee is a code owner

@kshitij12345 kshitij12345 Awaiting requested review from kshitij12345 kshitij12345 is a code owner

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@soulitzer soulitzer Awaiting requested review from soulitzer soulitzer is a code owner

1 more reviewer

@zeshengzong zeshengzong zeshengzong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: compiled autograd compiled_autograd module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: inductor module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration NNC oncall: distributed Add this issue/PR to distributed oncall triage queue open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.